livie
/
phoenix-firestorm
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

A reference being null would be undefined behavior and the compiler will optimize such checks away. Also dereferencing a nullptr beforehand would be undefined behavior too. 

Replace this with something well formed.
meow-7.2.2
Nicky 2018-04-03 11:13:41 +02:00
parent 9dff41dcc3
commit 03e9b73780
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
indra/newview/llface.cpp
View File

@ -983,13 +983,16 @@ void LLFace::getPlanarProjectedParams(LLQuaternion* face_rot, LLVector3* face_po
{
const LLMatrix4& vol_mat = getWorldMatrix();
const LLVolumeFace& vf = getViewerObject()->getVolume()->getVolumeFace(mTEOffset);
const LLVector4a& normal4a = vf.mNormals[0];
const LLVector4a& tangent = vf.mTangents[0];
if (!&tangent)
if( !vf.mNormals || !vf.mTangents )
{
LL_WARNS( ) << "Volume face without normals or tangents" << LL_ENDL;
return;
}
const LLVector4a& normal4a = vf.mNormals[0];
const LLVector4a& tangent = vf.mTangents[0];
LLVector4a binormal4a;
binormal4a.setCross3(normal4a, tangent);
binormal4a.mul(tangent.getF32ptr()[3]);