livie
/
phoenix-firestorm
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

DRTVWR-494: Streamline LLEventTimer::updateClass(). 

No need to capture a separate list of completed LLEventTimer instances to
delete after the primary loop, since at this point we're looping over a
snapshot and can directly delete each completed timer.
master
Nat Goodspeed 2019-12-03 11:36:04 -05:00
parent 7a09a5391a
commit 0c42f50d6b
1 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
indra/llcommon/lleventtimer.cpp
View File

@ -57,7 +57,6 @@ LLEventTimer::~LLEventTimer()
//static
void LLEventTimer::updateClass()
{
std::list<LLEventTimer*> completed_timers;
for (auto& timer : instance_snapshot())
{
F32 et = timer.mEventTimer.getElapsedTimeF32();
@ -65,20 +64,10 @@ void LLEventTimer::updateClass()
timer.mEventTimer.reset();
if ( timer.tick() )
{
completed_timers.push_back( &timer );
delete &timer;
}
}
}
if ( completed_timers.size() > 0 )
{
for (std::list<LLEventTimer*>::iterator completed_iter = completed_timers.begin();
completed_iter != completed_timers.end();
completed_iter++ )
{
delete *completed_iter;
}
}
}