From 61a08406c750a618058cac90de6db325355da8d3 Mon Sep 17 00:00:00 2001 From: Maxim Nikolenko Date: Wed, 4 Jan 2023 20:27:12 +0200 Subject: [PATCH 01/15] SL-18892 FIXED Mac build fails locally --- indra/cmake/Copy3rdPartyLibs.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/indra/cmake/Copy3rdPartyLibs.cmake b/indra/cmake/Copy3rdPartyLibs.cmake index 7495de00d5..e1508ed0c0 100644 --- a/indra/cmake/Copy3rdPartyLibs.cmake +++ b/indra/cmake/Copy3rdPartyLibs.cmake @@ -295,6 +295,6 @@ if(DARWIN) # that end up in any of the above SHARED_LIB_STAGING_DIR_MUMBLE # directories. add_custom_command( TARGET stage_third_party_libs POST_BUILD - COMMAND cmake -E create_symlink ${SHARED_LIB_STAGING_DIR} ${CMAKE_BINARY_DIR}/sharedlibs/Resources + COMMAND ${CMAKE_COMMAND} -E create_symlink ${SHARED_LIB_STAGING_DIR} ${CMAKE_BINARY_DIR}/sharedlibs/Resources ) endif() From 24839c8cf601cac5dbc9ca49166470f0263f7e3c Mon Sep 17 00:00:00 2001 From: Maxim Nikolenko Date: Thu, 5 Jan 2023 19:13:57 +0200 Subject: [PATCH 02/15] SL-18884 Remove dead spot from Back button --- .../xui/en/panel_performance_autoadjustments.xml | 12 +++++++----- .../default/xui/en/panel_performance_complexity.xml | 12 +++++++----- .../skins/default/xui/en/panel_performance_huds.xml | 12 +++++++----- .../default/xui/en/panel_performance_nearby.xml | 12 +++++++----- .../default/xui/en/panel_performance_preferences.xml | 12 +++++++----- 5 files changed, 35 insertions(+), 25 deletions(-) diff --git a/indra/newview/skins/default/xui/en/panel_performance_autoadjustments.xml b/indra/newview/skins/default/xui/en/panel_performance_autoadjustments.xml index 5d4ffd232b..ab7b4d3ee7 100644 --- a/indra/newview/skins/default/xui/en/panel_performance_autoadjustments.xml +++ b/indra/newview/skins/default/xui/en/panel_performance_autoadjustments.xml @@ -24,12 +24,14 @@ + width="32"> Back Preferred frame rate diff --git a/indra/newview/skins/default/xui/en/panel_performance_complexity.xml b/indra/newview/skins/default/xui/en/panel_performance_complexity.xml index 954fd0a8c1..cd3f610a92 100644 --- a/indra/newview/skins/default/xui/en/panel_performance_complexity.xml +++ b/indra/newview/skins/default/xui/en/panel_performance_complexity.xml @@ -24,12 +24,14 @@ + width="32"> Back Your avatar complexity diff --git a/indra/newview/skins/default/xui/en/panel_performance_huds.xml b/indra/newview/skins/default/xui/en/panel_performance_huds.xml index 289f865eb7..2fddcb3b9e 100644 --- a/indra/newview/skins/default/xui/en/panel_performance_huds.xml +++ b/indra/newview/skins/default/xui/en/panel_performance_huds.xml @@ -24,12 +24,14 @@ + width="32"> Back Your active HUDs diff --git a/indra/newview/skins/default/xui/en/panel_performance_nearby.xml b/indra/newview/skins/default/xui/en/panel_performance_nearby.xml index e80bf592e4..cb795e59a9 100644 --- a/indra/newview/skins/default/xui/en/panel_performance_nearby.xml +++ b/indra/newview/skins/default/xui/en/panel_performance_nearby.xml @@ -24,12 +24,14 @@ + width="32"> Back Avatars nearby diff --git a/indra/newview/skins/default/xui/en/panel_performance_preferences.xml b/indra/newview/skins/default/xui/en/panel_performance_preferences.xml index ee8105eac9..9c1a3ebd9e 100644 --- a/indra/newview/skins/default/xui/en/panel_performance_preferences.xml +++ b/indra/newview/skins/default/xui/en/panel_performance_preferences.xml @@ -24,12 +24,14 @@ + width="32"> Back Graphics settings From 495e34b84fa34ae5394f33f6f1175e959c56e769 Mon Sep 17 00:00:00 2001 From: Maxim Nikolenko Date: Tue, 10 Jan 2023 16:29:28 +0200 Subject: [PATCH 03/15] SL-18922 FIXED Imposters load with attachments using Perf floater --- indra/newview/pipeline.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/indra/newview/pipeline.cpp b/indra/newview/pipeline.cpp index ad47b3d154..51d7082b40 100644 --- a/indra/newview/pipeline.cpp +++ b/indra/newview/pipeline.cpp @@ -10871,11 +10871,9 @@ void LLPipeline::generateImpostor(LLVOAvatar* avatar, bool preview_avatar) << " is " << ( too_complex ? "" : "not ") << "too complex" << LL_ENDL; - bool too_slow = avatar->isTooSlow(); - pushRenderTypeMask(); - if ( !too_slow && ( visually_muted || too_complex ) ) + if (visually_muted || too_complex) { // only show jelly doll geometry andRenderTypeMask(LLPipeline::RENDER_TYPE_AVATAR, From 020bfa66ba9f1fee3e403595a1d6c95332bb16f7 Mon Sep 17 00:00:00 2001 From: Maxim Nikolenko Date: Tue, 10 Jan 2023 22:53:32 +0200 Subject: [PATCH 04/15] SL-18923 Add Reset to default settings button --- indra/newview/llfloaterperformance.cpp | 10 ++++++++ indra/newview/llfloaterperformance.h | 1 + indra/newview/llfloaterpreference.cpp | 6 +++++ indra/newview/llfloaterpreference.h | 2 ++ .../xui/en/panel_performance_preferences.xml | 25 +++++++++++++------ 5 files changed, 36 insertions(+), 8 deletions(-) diff --git a/indra/newview/llfloaterperformance.cpp b/indra/newview/llfloaterperformance.cpp index 36912971d9..88319b170f 100644 --- a/indra/newview/llfloaterperformance.cpp +++ b/indra/newview/llfloaterperformance.cpp @@ -127,6 +127,7 @@ BOOL LLFloaterPerformance::postBuild() mObjectList->setIconClickedCallback(boost::bind(&LLFloaterPerformance::detachItem, this, _1)); mSettingsPanel->getChild("advanced_btn")->setCommitCallback(boost::bind(&LLFloaterPerformance::onClickAdvanced, this)); + mSettingsPanel->getChild("defaults_btn")->setCommitCallback(boost::bind(&LLFloaterPerformance::onClickDefaults, this)); mSettingsPanel->getChild("graphics_quality")->setCommitCallback(boost::bind(&LLFloaterPerformance::onChangeQuality, this, _2)); mSettingsPanel->getChild("advanced_lighting_model")->setMouseDownCallback(boost::bind(&LLFloaterPerformance::onClickAdvancedLighting, this)); mSettingsPanel->getChild("ShadowDetail")->setMouseDownCallback(boost::bind(&LLFloaterPerformance::onClickShadows, this)); @@ -477,6 +478,15 @@ void LLFloaterPerformance::onClickAdvanced() LLFloaterReg::showInstance("prefs_graphics_advanced"); } +void LLFloaterPerformance::onClickDefaults() +{ + LLFloaterPreference* instance = LLFloaterReg::getTypedInstance("preferences"); + if (instance) + { + instance->setRecommendedSettings(); + } +} + void LLFloaterPerformance::onChangeQuality(const LLSD& data) { LLFloaterPreference* instance = LLFloaterReg::getTypedInstance("preferences"); diff --git a/indra/newview/llfloaterperformance.h b/indra/newview/llfloaterperformance.h index 09bcd18bb5..6a72f3d7c5 100644 --- a/indra/newview/llfloaterperformance.h +++ b/indra/newview/llfloaterperformance.h @@ -61,6 +61,7 @@ private: void setFPSText(); void onClickAdvanced(); + void onClickDefaults(); void onChangeQuality(const LLSD& data); void onClickHideAvatars(); void onClickExceptions(); diff --git a/indra/newview/llfloaterpreference.cpp b/indra/newview/llfloaterpreference.cpp index 76633a46a9..bb4ddf5969 100644 --- a/indra/newview/llfloaterpreference.cpp +++ b/indra/newview/llfloaterpreference.cpp @@ -788,6 +788,12 @@ void LLFloaterPreference::setHardwareDefaults() saveGraphicsPreset(preset_graphic_active); saveSettings(); // save here to be able to return to the previous preset by Cancel } + setRecommendedSettings(); +} + +void LLFloaterPreference::setRecommendedSettings() +{ + gSavedSettings.setBOOL("AutoTuneFPS", FALSE); LLFeatureManager::getInstance()->applyRecommendedSettings(); diff --git a/indra/newview/llfloaterpreference.h b/indra/newview/llfloaterpreference.h index d5d0aca939..32a55a2948 100644 --- a/indra/newview/llfloaterpreference.h +++ b/indra/newview/llfloaterpreference.h @@ -199,6 +199,8 @@ public: void saveCameraPreset(std::string& preset); void saveGraphicsPreset(std::string& preset); + void setRecommendedSettings(); + private: void onDeleteTranscripts(); diff --git a/indra/newview/skins/default/xui/en/panel_performance_preferences.xml b/indra/newview/skins/default/xui/en/panel_performance_preferences.xml index 9c1a3ebd9e..b52c19d5e3 100644 --- a/indra/newview/skins/default/xui/en/panel_performance_preferences.xml +++ b/indra/newview/skins/default/xui/en/panel_performance_preferences.xml @@ -47,14 +47,23 @@ Graphics settings - - + name="display_desc" + top_delta="5" + left_pad="15" + wrap="true" + width="225"> + Your display supports up to [FPS_LIMIT] fps. + + width="115"> Settings affect + width="160"> + + From 788ba76bdf5dcc0a018a6b53bc1cc8f359e85f34 Mon Sep 17 00:00:00 2001 From: Maxim Nikolenko Date: Thu, 2 Feb 2023 16:17:09 +0200 Subject: [PATCH 15/15] SL-19094 Move Desired frame rate button to top level --- indra/newview/llfloaterperformance.cpp | 1 + .../default/xui/en/floater_performance.xml | 95 ++++++++++--------- .../en/panel_performance_autoadjustments.xml | 11 ++- 3 files changed, 59 insertions(+), 48 deletions(-) diff --git a/indra/newview/llfloaterperformance.cpp b/indra/newview/llfloaterperformance.cpp index ba45648bd9..5eb58b9482 100644 --- a/indra/newview/llfloaterperformance.cpp +++ b/indra/newview/llfloaterperformance.cpp @@ -151,6 +151,7 @@ BOOL LLFloaterPerformance::postBuild() LLStringExplicit fps_limit(llformat("%d", gViewerWindow->getWindow()->getRefreshRate())); mAutoadjustmentsPanel->getChild("vsync_desc_limit")->setTextArg("[FPS_LIMIT]", fps_limit); mAutoadjustmentsPanel->getChild("display_desc")->setTextArg("[FPS_LIMIT]", fps_limit); + mAutoadjustmentsPanel->getChild("defaults_btn")->setCommitCallback(boost::bind(&LLFloaterPerformance::onClickDefaults, this)); mStartAutotuneBtn = mAutoadjustmentsPanel->getChild("start_autotune"); mStopAutotuneBtn = mAutoadjustmentsPanel->getChild("stop_autotune"); diff --git a/indra/newview/skins/default/xui/en/floater_performance.xml b/indra/newview/skins/default/xui/en/floater_performance.xml index ee88701037..d1a1119f77 100644 --- a/indra/newview/skins/default/xui/en/floater_performance.xml +++ b/indra/newview/skins/default/xui/en/floater_performance.xml @@ -4,6 +4,7 @@ layout="topleft" name="performance" save_rect="true" + reuse_instance="true" title="IMPROVE GRAPHICS SPEED" width="580"> + + Auto-adjust settings (recommended) + + + Allow automatic adjustments to reach your preferred frame rate. + + + + - - - Preferred frame rate - - - Allow automatic adjustments to reach your preferred frame rate (advanced). - - - - Preferred frame rate + Auto-adjust settings +