From 4f400bad6d65a20d6b703df4e573b31557b3a164 Mon Sep 17 00:00:00 2001 From: Ansariel Date: Sun, 7 Jan 2018 04:50:04 +0100 Subject: [PATCH 1/7] FIRE-21546: Don't close docked script floater if IMs arrive, but only if IMs shown in tabs - still hide when using docked windows! --- indra/newview/llscriptfloater.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/indra/newview/llscriptfloater.cpp b/indra/newview/llscriptfloater.cpp index 608507a0d2..98b253f291 100644 --- a/indra/newview/llscriptfloater.cpp +++ b/indra/newview/llscriptfloater.cpp @@ -72,7 +72,10 @@ LLUUID notification_id_to_object_id(const LLUUID& notification_id) LLScriptFloater::LLScriptFloater(const LLSD& key) -: LLDockableFloater(NULL, true, key) +// FIRE-21546: Don't close docked floater if IMs arrive, but only if IMs shown in tabs - still hide when using docked windows! +//: LLDockableFloater(NULL, true, key) +: LLDockableFloater(NULL, gSavedSettings.getS32("FSChatWindow") != 1, key) +// , mScriptForm(NULL) , mSaveFloaterPosition(false) { From d6b1eadf2ddb7d4c2d21c711ebf6cd3e271eaac9 Mon Sep 17 00:00:00 2001 From: Beq Date: Sun, 7 Jan 2018 23:26:10 +0000 Subject: [PATCH 2/7] Changes for FIRE-22130 - re-baselining RenderolumeLODFactor advice and warnings. updates phototools to limit range to < 8 as values much above that can cause errors updates warning to appear above 4 not at 4 updates the language used in warnings/tool_tips etc across the viewer --- indra/newview/app_settings/settings.xml | 4 ++-- indra/newview/llstartup.cpp | 14 ++++++++++---- indra/newview/llviewercontrol.cpp | 2 +- .../skins/default/xui/en/floater_phototools.xml | 12 ++++++------ .../newview/skins/default/xui/en/notifications.xml | 14 ++++++++------ .../default/xui/en/panel_preferences_graphics1.xml | 1 + .../skins/starlight/xui/en/floater_phototools.xml | 12 ++++++------ .../starlightcui/xui/en/floater_phototools.xml | 12 ++++++------ 8 files changed, 40 insertions(+), 31 deletions(-) diff --git a/indra/newview/app_settings/settings.xml b/indra/newview/app_settings/settings.xml index b2e109064a..347926ec50 100644 --- a/indra/newview/app_settings/settings.xml +++ b/indra/newview/app_settings/settings.xml @@ -13022,13 +13022,13 @@ Change of this parameter will affect the layout of buttons in notification toast RenderVolumeLODFactor Comment - Controls level of detail of primitives (multiplier for current screen area when calculated level of detail) + Influences the distance at which the viewer will display a lower detail model. Higher values = more lag. IMPORTANT: Please disregard advice to increase this value, such as is commonly distributed in notecards. Persist 1 Type F32 Value - 1.0 + 2.0 SanityCheckType LessThanEquals SanityValue diff --git a/indra/newview/llstartup.cpp b/indra/newview/llstartup.cpp index e30bf28e87..b9411f00b2 100644 --- a/indra/newview/llstartup.cpp +++ b/indra/newview/llstartup.cpp @@ -3039,12 +3039,18 @@ void login_show() FSPanelLogin::show( gViewerWindow->getWindowRectScaled(), login_callback, NULL ); // [FS Login Panel] - // Warning about too high LOD on startup - if (gSavedSettings.getF32("RenderVolumeLODFactor") >= 4.0f) + // [FIRE-22130] for LOD Factors > 4 reset to the detected dafault + F32 old_val = gSavedSettings.getF32("RenderVolumeLODFactor"); + if (old_val > 4.0f) { - LLNotificationsUtil::add("RenderVolumeLODFactorWarning"); + U32 gfx_level = gSavedSettings.getU32("RenderQualityPerformance"); + F32 new_val = 2.0; //majority + if (gfx_level == 0) new_val = 1.125; // low = 0 + if (gfx_level > 5) new_val = 3.0; // ultra = 6 + gSavedSettings.setF32("RenderVolumeLODFactor", new_val); + LL_INFOS("AppInit") << "LOD Factor reset to sane value. Was " << old_val << " now " << gSavedSettings.getF32("RenderVolumeLODFactor") << LL_ENDL; } - // + // } diff --git a/indra/newview/llviewercontrol.cpp b/indra/newview/llviewercontrol.cpp index 291745ae7a..5c9aacb58e 100644 --- a/indra/newview/llviewercontrol.cpp +++ b/indra/newview/llviewercontrol.cpp @@ -286,7 +286,7 @@ static bool handleVolumeLODChanged(const LLSD& newvalue) LLVOVolume::sDistanceFactor = 1.f-LLVOVolume::sLODFactor * 0.1f; // Warning about too high LOD on LOD change - if (LLVOVolume::sLODFactor >= 4.0f) + if (LLVOVolume::sLODFactor > 4.0f) { LLNotificationsUtil::add("RenderVolumeLODFactorWarning"); } diff --git a/indra/newview/skins/default/xui/en/floater_phototools.xml b/indra/newview/skins/default/xui/en/floater_phototools.xml index d4a940c43b..f7acd9c24f 100644 --- a/indra/newview/skins/default/xui/en/floater_phototools.xml +++ b/indra/newview/skins/default/xui/en/floater_phototools.xml @@ -2676,7 +2676,7 @@ layout="topleft" left="5" top_pad="5" - tool_tip="Controls the detail of prims. Higher values produce greater detail for objects." + tool_tip="Controls when lower-detail objects can be used to reduce rendering cost. Higher values cause lag, use with care." width="80"> Obj. Detail @@ -2685,11 +2685,11 @@ control_name="RenderVolumeLODFactor" follows="left|top" height="16" - increment="1" + increment="0.125" layout="topleft" left_pad="-20" min_val="0" - max_val="15" + max_val="8.0" top_delta="-2" width="127"/> + increment="0.125"/>