From 8a9a9295999a67e97b16c3e0ff4b9fdfd8298904 Mon Sep 17 00:00:00 2001 From: AndreyL ProductEngine Date: Thu, 5 Sep 2019 23:46:59 +0300 Subject: [PATCH 1/8] SL-11848 Fixed login crash (Face with no texture index references indexed texture draw info) --- indra/newview/llface.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/indra/newview/llface.cpp b/indra/newview/llface.cpp index 912bde9986..1d782cdabe 100644 --- a/indra/newview/llface.cpp +++ b/indra/newview/llface.cpp @@ -462,7 +462,7 @@ void LLFace::setTextureIndex(U8 index) } else { - if (mDrawInfo && !mDrawInfo->mTextureList.empty()) + if (mDrawInfo && mDrawInfo->mTextureList.size() <= 1) { LL_ERRS() << "Face with no texture index references indexed texture draw info." << LL_ENDL; } From 4bcf3bc3ed5b103b1f28d05253f2df37aebbe52b Mon Sep 17 00:00:00 2001 From: andreykproductengine Date: Wed, 11 Sep 2019 19:02:59 +0300 Subject: [PATCH 2/8] SL-11218 Update Avatar Texture Debugger to reflect new bake channels --- .../xui/en/floater_avatar_textures.xml | 137 +++++++++++++++++- 1 file changed, 136 insertions(+), 1 deletion(-) diff --git a/indra/newview/skins/default/xui/en/floater_avatar_textures.xml b/indra/newview/skins/default/xui/en/floater_avatar_textures.xml index bac3ea86f1..6540f5e348 100644 --- a/indra/newview/skins/default/xui/en/floater_avatar_textures.xml +++ b/indra/newview/skins/default/xui/en/floater_avatar_textures.xml @@ -28,11 +28,13 @@ name="scroll_content_panel" follows="left|top" min_height="300" + min_width="300" layout="topleft" top="0" background_visible="false" left="0" - height="680"> + height="1165" + width="1015"> + + + + + + + + + + + + + + + + + + + + + From 3cb11fe9560d0b6e9996f47ae0f098f106562610 Mon Sep 17 00:00:00 2001 From: maxim_productengine Date: Thu, 12 Sep 2019 14:25:25 +0300 Subject: [PATCH 3/8] SL-11157 Restore change that was lost in merge --- indra/newview/skins/default/xui/de/floater_about_land.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/indra/newview/skins/default/xui/de/floater_about_land.xml b/indra/newview/skins/default/xui/de/floater_about_land.xml index 4dd64cba2a..8f55b3297f 100644 --- a/indra/newview/skins/default/xui/de/floater_about_land.xml +++ b/indra/newview/skins/default/xui/de/floater_about_land.xml @@ -30,7 +30,7 @@ Immer - + Nur neue Benutzer From d1fdb6995b526957acde8a08e0827195d77ae136 Mon Sep 17 00:00:00 2001 From: maxim_productengine Date: Fri, 13 Sep 2019 16:26:17 +0300 Subject: [PATCH 4/8] SL-11912 FIXED Sending a group invitation causes the UI to flip from the Members tab to Roles. --- indra/newview/llfloatergroupinvite.cpp | 11 +++++++---- indra/newview/llfloatergroupinvite.h | 2 +- indra/newview/llpanelgrouproles.cpp | 2 +- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/indra/newview/llfloatergroupinvite.cpp b/indra/newview/llfloatergroupinvite.cpp index 7fdba8734a..30c90ac184 100644 --- a/indra/newview/llfloatergroupinvite.cpp +++ b/indra/newview/llfloatergroupinvite.cpp @@ -108,7 +108,7 @@ LLFloaterGroupInvite::~LLFloaterGroupInvite() } // static -void LLFloaterGroupInvite::showForGroup(const LLUUID& group_id, uuid_vec_t *agent_ids) +void LLFloaterGroupInvite::showForGroup(const LLUUID& group_id, uuid_vec_t *agent_ids, bool request_update) { const LLFloater::Params& floater_params = LLFloater::getDefaultParams(); S32 floater_header_size = floater_params.header_height; @@ -126,9 +126,12 @@ void LLFloaterGroupInvite::showForGroup(const LLUUID& group_id, uuid_vec_t *agen group_id, (LLFloaterGroupInvite*)NULL); - // refresh group information - gAgent.sendAgentDataUpdateRequest(); - LLGroupMgr::getInstance()->clearGroupData(group_id); + if (request_update) + { + // refresh group information + gAgent.sendAgentDataUpdateRequest(); + LLGroupMgr::getInstance()->clearGroupData(group_id); + } if (!fgi) diff --git a/indra/newview/llfloatergroupinvite.h b/indra/newview/llfloatergroupinvite.h index f6a3ca5550..657e5711f0 100644 --- a/indra/newview/llfloatergroupinvite.h +++ b/indra/newview/llfloatergroupinvite.h @@ -37,7 +37,7 @@ class LLFloaterGroupInvite public: virtual ~LLFloaterGroupInvite(); - static void showForGroup(const LLUUID &group_id, uuid_vec_t *agent_ids = NULL); + static void showForGroup(const LLUUID &group_id, uuid_vec_t *agent_ids = NULL, bool request_update = true); protected: LLFloaterGroupInvite(const LLUUID& group_id = LLUUID::null); diff --git a/indra/newview/llpanelgrouproles.cpp b/indra/newview/llpanelgrouproles.cpp index 0efb234015..e3d75d5604 100644 --- a/indra/newview/llpanelgrouproles.cpp +++ b/indra/newview/llpanelgrouproles.cpp @@ -1153,7 +1153,7 @@ void LLPanelGroupMembersSubTab::onInviteMember(void *userdata) void LLPanelGroupMembersSubTab::handleInviteMember() { - LLFloaterGroupInvite::showForGroup(mGroupID); + LLFloaterGroupInvite::showForGroup(mGroupID, NULL, false); } void LLPanelGroupMembersSubTab::onEjectMembers(void *userdata) From f2d35e8e568278f9269da11a5d589fc39f59f296 Mon Sep 17 00:00:00 2001 From: andreykproductengine Date: Tue, 17 Sep 2019 15:56:07 +0300 Subject: [PATCH 5/8] SL-11779 Resolved perfomance drop with negative RenderShadowResolutionScale --- indra/newview/app_settings/settings.xml | 2 +- indra/newview/pipeline.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/indra/newview/app_settings/settings.xml b/indra/newview/app_settings/settings.xml index b9cb613b96..68e39899f0 100644 --- a/indra/newview/app_settings/settings.xml +++ b/indra/newview/app_settings/settings.xml @@ -9287,7 +9287,7 @@ RenderShadowResolutionScale Comment - Scale of shadow map resolution vs. screen resolution + Scale of shadow map resolution vs. screen resolution (only positivie values are allowed) Persist 1 Type diff --git a/indra/newview/pipeline.cpp b/indra/newview/pipeline.cpp index 65438ef05d..eb2d3bf873 100644 --- a/indra/newview/pipeline.cpp +++ b/indra/newview/pipeline.cpp @@ -973,7 +973,7 @@ bool LLPipeline::allocateScreenBuffer(U32 resX, U32 resY, U32 samples) mDeferredLight.release(); } - F32 scale = RenderShadowResolutionScale; + F32 scale = llmax(0.f, RenderShadowResolutionScale); if (shadow_detail > 0) { //allocate 4 sun shadow maps From e2dac1420122894499c8d8a26edc2ba51c43f28c Mon Sep 17 00:00:00 2001 From: maxim_productengine Date: Wed, 18 Sep 2019 14:16:40 +0300 Subject: [PATCH 6/8] SL-11921 FIXED Some translations overlap the 'About Land' and 'Preferences' UI --- .../skins/default/xui/de/panel_preferences_chat.xml | 2 +- .../default/xui/de/panel_preferences_graphics1.xml | 4 ++-- .../skins/default/xui/en/floater_about_land.xml | 2 +- .../skins/default/xui/en/panel_preferences_chat.xml | 1 + .../skins/default/xui/es/floater_about_land.xml | 4 ++-- .../skins/default/xui/es/panel_preferences_chat.xml | 2 +- .../skins/default/xui/es/panel_preferences_setup.xml | 2 +- .../skins/default/xui/fr/floater_about_land.xml | 6 +++--- .../skins/default/xui/fr/panel_preferences_chat.xml | 2 +- .../skins/default/xui/it/floater_about_land.xml | 6 +++--- .../skins/default/xui/pt/floater_about_land.xml | 4 ++-- .../skins/default/xui/ru/floater_about_land.xml | 10 +++++----- .../skins/default/xui/ru/panel_preferences_chat.xml | 6 +++--- .../skins/default/xui/ru/panel_preferences_setup.xml | 2 +- .../skins/default/xui/tr/floater_about_land.xml | 4 ++-- 15 files changed, 29 insertions(+), 28 deletions(-) diff --git a/indra/newview/skins/default/xui/de/panel_preferences_chat.xml b/indra/newview/skins/default/xui/de/panel_preferences_chat.xml index 550a99fe0a..51c82c97f8 100644 --- a/indra/newview/skins/default/xui/de/panel_preferences_chat.xml +++ b/indra/newview/skins/default/xui/de/panel_preferences_chat.xml @@ -13,7 +13,7 @@ - + diff --git a/indra/newview/skins/default/xui/de/panel_preferences_graphics1.xml b/indra/newview/skins/default/xui/de/panel_preferences_graphics1.xml index ff0a6614bd..e0aa9fe4a9 100644 --- a/indra/newview/skins/default/xui/de/panel_preferences_graphics1.xml +++ b/indra/newview/skins/default/xui/de/panel_preferences_graphics1.xml @@ -3,10 +3,10 @@ (Keine) - + Qualität und Geschwindigkeit: - + Niedrig diff --git a/indra/newview/skins/default/xui/en/floater_about_land.xml b/indra/newview/skins/default/xui/en/floater_about_land.xml index 9f853fd960..a143adfa06 100644 --- a/indra/newview/skins/default/xui/en/floater_about_land.xml +++ b/indra/newview/skins/default/xui/en/floater_about_land.xml @@ -1800,7 +1800,7 @@ Only large parcels can be listed in search. Music URL: diff --git a/indra/newview/skins/default/xui/es/floater_about_land.xml b/indra/newview/skins/default/xui/es/floater_about_land.xml index 998d2a8863..57a1b2ec1e 100644 --- a/indra/newview/skins/default/xui/es/floater_about_land.xml +++ b/indra/newview/skins/default/xui/es/floater_about_land.xml @@ -362,7 +362,7 @@ Sólo las parcelas más grandes pueden listarse en la búsqueda. Foto: - + Los avatares de otras parcelas pueden ver a los avatares de esta parcela y chatear con ellos @@ -444,7 +444,7 @@ los media: Una o más de esta opciones está configurada a nivel del estado - + diff --git a/indra/newview/skins/default/xui/es/panel_preferences_chat.xml b/indra/newview/skins/default/xui/es/panel_preferences_chat.xml index f7e036efd7..388a5d84d2 100644 --- a/indra/newview/skins/default/xui/es/panel_preferences_chat.xml +++ b/indra/newview/skins/default/xui/es/panel_preferences_chat.xml @@ -13,7 +13,7 @@ - + diff --git a/indra/newview/skins/default/xui/es/panel_preferences_setup.xml b/indra/newview/skins/default/xui/es/panel_preferences_setup.xml index 1b191d3e46..36888850c4 100644 --- a/indra/newview/skins/default/xui/es/panel_preferences_setup.xml +++ b/indra/newview/skins/default/xui/es/panel_preferences_setup.xml @@ -30,7 +30,7 @@ - + Configuración de proxy: diff --git a/indra/newview/skins/default/xui/fr/floater_about_land.xml b/indra/newview/skins/default/xui/fr/floater_about_land.xml index 219857eb99..fb65e71ee1 100644 --- a/indra/newview/skins/default/xui/fr/floater_about_land.xml +++ b/indra/newview/skins/default/xui/fr/floater_about_land.xml @@ -366,10 +366,10 @@ Seules les parcelles de grande taille peuvent apparaître dans la recherche. Photo : - + Les avatars sur d'autres parcelles peuvent voir et chatter avec les avatars sur cette parcelle. - + Lieu d'arrivée : [LANDING] @@ -449,7 +449,7 @@ musique : Au moins une de ces options est définie au niveau du domaine. - + diff --git a/indra/newview/skins/default/xui/fr/panel_preferences_chat.xml b/indra/newview/skins/default/xui/fr/panel_preferences_chat.xml index 422243445b..a0f2e0eba7 100644 --- a/indra/newview/skins/default/xui/fr/panel_preferences_chat.xml +++ b/indra/newview/skins/default/xui/fr/panel_preferences_chat.xml @@ -13,7 +13,7 @@ - + diff --git a/indra/newview/skins/default/xui/it/floater_about_land.xml b/indra/newview/skins/default/xui/it/floater_about_land.xml index 0a7837e122..50e2d1a8de 100644 --- a/indra/newview/skins/default/xui/it/floater_about_land.xml +++ b/indra/newview/skins/default/xui/it/floater_about_land.xml @@ -367,10 +367,10 @@ Solamente terreni più grandi possono essere abilitati nella ricerca. Fotografia: - + Gli avatar di altri lotti possono vedere gli avatar che si trovano in questo lotto e chattare con loro - + Punto di atterraggio: [LANDING] @@ -449,7 +449,7 @@ Media: Una o più di queste impostazioni sono già impostate a livello regionale - + diff --git a/indra/newview/skins/default/xui/pt/floater_about_land.xml b/indra/newview/skins/default/xui/pt/floater_about_land.xml index ef71baa0b6..96e54bb9bc 100644 --- a/indra/newview/skins/default/xui/pt/floater_about_land.xml +++ b/indra/newview/skins/default/xui/pt/floater_about_land.xml @@ -362,10 +362,10 @@ Apenas lotes maiores podem ser listados na busca. Foto: - + Avatares em outros lotes podem ver e conversar com avatares neste lote - + Ponto de Aterrissagem: [LANDING] diff --git a/indra/newview/skins/default/xui/ru/floater_about_land.xml b/indra/newview/skins/default/xui/ru/floater_about_land.xml index 1ae6df76d9..222572b4bf 100644 --- a/indra/newview/skins/default/xui/ru/floater_about_land.xml +++ b/indra/newview/skins/default/xui/ru/floater_about_land.xml @@ -338,7 +338,7 @@ - + @@ -360,10 +360,10 @@ Снимок: - + Аватары с других участков могут видеть аватары на этом участке и общаться с ними - + В точку телепортации: [LANDING] @@ -372,7 +372,7 @@ Вариант телепортации: - + @@ -439,7 +439,7 @@ Часть этих параметров установлена на уровне землевладения - + diff --git a/indra/newview/skins/default/xui/ru/panel_preferences_chat.xml b/indra/newview/skins/default/xui/ru/panel_preferences_chat.xml index c2fcac8840..03a714f266 100644 --- a/indra/newview/skins/default/xui/ru/panel_preferences_chat.xml +++ b/indra/newview/skins/default/xui/ru/panel_preferences_chat.xml @@ -5,15 +5,15 @@ - + Размер шрифта: - + - + diff --git a/indra/newview/skins/default/xui/ru/panel_preferences_setup.xml b/indra/newview/skins/default/xui/ru/panel_preferences_setup.xml index d4d0ef9e7c..137e047d97 100644 --- a/indra/newview/skins/default/xui/ru/panel_preferences_setup.xml +++ b/indra/newview/skins/default/xui/ru/panel_preferences_setup.xml @@ -14,7 +14,7 @@ Браузер: - + diff --git a/indra/newview/skins/default/xui/tr/floater_about_land.xml b/indra/newview/skins/default/xui/tr/floater_about_land.xml index 48b16e2fde..1101e5055a 100644 --- a/indra/newview/skins/default/xui/tr/floater_about_land.xml +++ b/indra/newview/skins/default/xui/tr/floater_about_land.xml @@ -360,10 +360,10 @@ Sadece büyük parseller aramada görünür. Anlık Görüntü: - + Diğer parsellerdeki avatarlar bu parseldeki avatarları görebilir ve onlarla sohbet edebilir - + İniş Noktası: [LANDING] From 246db89a939d7965feb234600bcbd07860871351 Mon Sep 17 00:00:00 2001 From: maxim_productengine Date: Thu, 19 Sep 2019 12:20:27 +0300 Subject: [PATCH 7/8] SL-11951 FIXED Classifieds location field erroneously updates if an edit occurs in a different location. --- indra/newview/llpanelclassified.cpp | 1 + .../newview/skins/default/xui/en/panel_classifieds_list_item.xml | 1 - indra/newview/skins/default/xui/en/panel_edit_classified.xml | 1 - indra/newview/skins/default/xui/en/panel_pick_info.xml | 1 - indra/newview/skins/default/xui/en/panel_pick_list_item.xml | 1 - 5 files changed, 1 insertion(+), 4 deletions(-) diff --git a/indra/newview/llpanelclassified.cpp b/indra/newview/llpanelclassified.cpp index 6d0c30fbf3..c0342eef4e 100644 --- a/indra/newview/llpanelclassified.cpp +++ b/indra/newview/llpanelclassified.cpp @@ -764,6 +764,7 @@ void LLPanelClassifiedEdit::processProperties(void* data, EAvatarProcessorType t setClassifiedName(c_info->name); setDescription(c_info->description); setSnapshotId(c_info->snapshot_id); + setParcelId(c_info->parcel_id); setPosGlobal(c_info->pos_global); setClassifiedLocation(createLocationText(c_info->parcel_name, c_info->sim_name, c_info->pos_global)); diff --git a/indra/newview/skins/default/xui/en/panel_classifieds_list_item.xml b/indra/newview/skins/default/xui/en/panel_classifieds_list_item.xml index 27c653bc35..d1175a9fe1 100644 --- a/indra/newview/skins/default/xui/en/panel_classifieds_list_item.xml +++ b/indra/newview/skins/default/xui/en/panel_classifieds_list_item.xml @@ -32,7 +32,6 @@ width="308"/> Date: Thu, 19 Sep 2019 14:54:55 +0300 Subject: [PATCH 8/8] SL-3221 Safeguard against crashes in LLDXHardware --- indra/llwindow/lldxhardware.cpp | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/indra/llwindow/lldxhardware.cpp b/indra/llwindow/lldxhardware.cpp index d4790f9f29..9397b831f7 100644 --- a/indra/llwindow/lldxhardware.cpp +++ b/indra/llwindow/lldxhardware.cpp @@ -613,6 +613,7 @@ BOOL LLDXHardware::getInfo(BOOL vram_only) IDxDiagContainer *device_containerp = NULL; IDxDiagContainer *file_containerp = NULL; IDxDiagContainer *driver_containerp = NULL; + DWORD dw_device_count; // CoCreate a IDxDiagProvider* LL_DEBUGS("AppInit") << "CoCreateInstance IID_IDxDiagProvider" << LL_ENDL; @@ -663,9 +664,18 @@ BOOL LLDXHardware::getInfo(BOOL vram_only) hr = dx_diag_rootp->GetChildContainer(L"DxDiag_DisplayDevices", &devices_containerp); if(FAILED(hr) || !devices_containerp) { + // do not release 'dirty' devices_containerp at this stage, only dx_diag_rootp + devices_containerp = NULL; goto LCleanup; } + // make sure there is something inside + hr = devices_containerp->GetNumberOfChildContainers(&dw_device_count); + if (FAILED(hr) || dw_device_count == 0) + { + goto LCleanup; + } + // Get device 0 LL_DEBUGS("AppInit") << "devices_containerp->GetChildContainer" << LL_ENDL; hr = devices_containerp->GetChildContainer(L"0", &device_containerp); @@ -872,6 +882,7 @@ LLSD LLDXHardware::getDisplayInfo() IDxDiagContainer *device_containerp = NULL; IDxDiagContainer *file_containerp = NULL; IDxDiagContainer *driver_containerp = NULL; + DWORD dw_device_count; // CoCreate a IDxDiagProvider* LL_INFOS() << "CoCreateInstance IID_IDxDiagProvider" << LL_ENDL; @@ -922,9 +933,18 @@ LLSD LLDXHardware::getDisplayInfo() hr = dx_diag_rootp->GetChildContainer(L"DxDiag_DisplayDevices", &devices_containerp); if(FAILED(hr) || !devices_containerp) { + // do not release 'dirty' devices_containerp at this stage, only dx_diag_rootp + devices_containerp = NULL; goto LCleanup; } + // make sure there is something inside + hr = devices_containerp->GetNumberOfChildContainers(&dw_device_count); + if (FAILED(hr) || dw_device_count == 0) + { + goto LCleanup; + } + // Get device 0 LL_INFOS() << "devices_containerp->GetChildContainer" << LL_ENDL; hr = devices_containerp->GetChildContainer(L"0", &device_containerp); @@ -976,6 +996,10 @@ LLSD LLDXHardware::getDisplayInfo() } LCleanup: + if (ret.emptyMap()) + { + LL_INFOS() << "Failed to get data, cleaning up" << LL_ENDL; + } SAFE_RELEASE(file_containerp); SAFE_RELEASE(driver_containerp); SAFE_RELEASE(device_containerp);