From 2c68d02395119109558c24d817527ffd5946b0e2 Mon Sep 17 00:00:00 2001 From: Rider Linden Date: Mon, 11 Jul 2016 16:33:11 -0700 Subject: [PATCH] MAINT-6565: Grab a shared pointer and encapsulate it into the bind call in place of this. Ensures that the impl is not deleted while the coroutine is active. --- indra/newview/lleventpoll.cpp | 7 +++---- indra/newview/lleventpoll.h | 2 +- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/indra/newview/lleventpoll.cpp b/indra/newview/lleventpoll.cpp index f729068c86..81aa11cf39 100644 --- a/indra/newview/lleventpoll.cpp +++ b/indra/newview/lleventpoll.cpp @@ -47,7 +47,7 @@ namespace LLEventPolling namespace Details { - class LLEventPollImpl + class LLEventPollImpl: public boost::enable_shared_from_this { public: LLEventPollImpl(const LLHost &sender); @@ -130,7 +130,7 @@ namespace Details { std::string coroname = LLCoros::instance().launch("LLEventPollImpl::eventPollCoro", - boost::bind(&LLEventPollImpl::eventPollCoro, this, url)); + boost::bind(&LLEventPollImpl::eventPollCoro, this->shared_from_this(), url)); LL_INFOS("LLEventPollImpl") << coroname << " with url '" << url << LL_ENDL; } } @@ -302,8 +302,7 @@ namespace Details LLEventPoll::LLEventPoll(const std::string& poll_url, const LLHost& sender): mImpl() { - mImpl = boost::unique_ptr - (new LLEventPolling::Details::LLEventPollImpl(sender)); + mImpl = boost::shared_ptr(new LLEventPolling::Details::LLEventPollImpl(sender)); mImpl->start(poll_url); } diff --git a/indra/newview/lleventpoll.h b/indra/newview/lleventpoll.h index e2afd9226b..d305135b18 100644 --- a/indra/newview/lleventpoll.h +++ b/indra/newview/lleventpoll.h @@ -57,7 +57,7 @@ public: private: - boost::unique_ptr mImpl; + boost::shared_ptr mImpl; };