From 3e30c2d28f5bb354e1dd1d54b5b5723f27f243eb Mon Sep 17 00:00:00 2001
From: Ansariel <ansariel.hiller@phoenixviewer.com>
Date: Thu, 10 Dec 2020 09:27:47 +0100
Subject: [PATCH] Return value can only be false here - make it obvious

---
 indra/llaudio/llstreamingaudio_fmodstudio.cpp | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/indra/llaudio/llstreamingaudio_fmodstudio.cpp b/indra/llaudio/llstreamingaudio_fmodstudio.cpp
index 5fef19d6d2..0d3e58b3e5 100644
--- a/indra/llaudio/llstreamingaudio_fmodstudio.cpp
+++ b/indra/llaudio/llstreamingaudio_fmodstudio.cpp
@@ -392,6 +392,7 @@ void LLStreamingAudio_FMODSTUDIO::setGain(F32 vol)
         Check_FMOD_Error(mFMODInternetStreamChannelp->setVolume(vol), "FMOD::Channel::setVolume");
     }
 }
+
 // <DKO> Streamtitle display
 // virtual
 bool LLStreamingAudio_FMODSTUDIO::getNewMetadata(LLSD& metadata)
@@ -404,14 +405,17 @@ bool LLStreamingAudio_FMODSTUDIO::getNewMetadata(LLSD& metadata)
             mNewMetadata = false;
             return true;
         }
-            
-        return mNewMetadata;
+        else
+        {
+            return false;
+        }
     }
 
     metadata = LLSD();
     return false;
 }
 // </DKO>
+
 ///////////////////////////////////////////////////////
 // manager of possibly-multiple internet audio streams