Added Jonathan Yap's mute getsure patch from LL code review for STORM-787

Modified only the option location in the sound preference floater
meow-7.2.2
Tank_Master 2011-06-12 17:52:51 -07:00
parent 8145800cba
commit 5de3a4074d
5 changed files with 46 additions and 7 deletions

View File

@ -3710,6 +3710,17 @@
<key>Value</key>
<integer>1</integer>
</map>
<key>EnableGestureSounds</key>
<map>
<key>Comment</key>
<string>Play sounds from gestures</string>
<key>Persist</key>
<integer>1</integer>
<key>Type</key>
<string>Boolean</string>
<key>Value</key>
<integer>1</integer>
</map>
<key>EnableMouselook</key>
<map>
<key>Comment</key>

View File

@ -322,6 +322,7 @@ LLFloaterPreference::LLFloaterPreference(const LLSD& key)
mCommitCallbackRegistrar.add("Pref.VoiceSetKey", boost::bind(&LLFloaterPreference::onClickSetKey, this));
mCommitCallbackRegistrar.add("Pref.EditMediaLists", boost::bind(&LLFloaterPreference::onClickSetKey, this));
mCommitCallbackRegistrar.add("Pref.VoiceSetMiddleMouse", boost::bind(&LLFloaterPreference::onClickSetMiddleMouse, this));
mCommitCallbackRegistrar.add("Pref.SetSounds", boost::bind(&LLFloaterPreference::onClickSetSounds, this));
// mCommitCallbackRegistrar.add("Pref.ClickSkipDialogs", boost::bind(&LLFloaterPreference::onClickSkipDialogs, this));
// mCommitCallbackRegistrar.add("Pref.ClickResetDialogs", boost::bind(&LLFloaterPreference::onClickResetDialogs, this));
mCommitCallbackRegistrar.add("Pref.ClickEnablePopup", boost::bind(&LLFloaterPreference::onClickEnablePopup, this));
@ -1364,6 +1365,14 @@ void LLFloaterPreference::onClickSetMiddleMouse()
p2t_line_editor->setValue(advanced_preferences->getString("middle_mouse"));
}
}
void LLFloaterPreference::onClickSetSounds()
{
// Disable Enable gesture sounds checkbox if the master sound is disabled
// or if sound effects are disabled.
getChild<LLCheckBoxCtrl>("gesture_audio_play_btn")->setEnabled(!gSavedSettings.getBOOL("MuteSounds"));
}
/*
void LLFloaterPreference::onClickSkipDialogs()
{

View File

@ -134,6 +134,7 @@ public:
void onClickSetKey();
void setKey(KEY key);
void onClickSetMiddleMouse();
void onClickSetSounds();
// void onClickSkipDialogs();
// void onClickResetDialogs();
void onClickEnablePopup();

View File

@ -4808,6 +4808,9 @@ void process_sound_trigger(LLMessageSystem *msg, void **)
if (pPeoplePanel)
pPeoplePanel->requestRadarChannelAlertSync();
}
// Don't play sounds from gestures if they are not enabled.
if (!gSavedSettings.getBOOL("EnableGestureSounds")) return;
gAudiop->triggerSound(sound_id, owner_id, gain, LLAudioEngine::AUDIO_TYPE_SFX, pos_global);
}

View File

@ -111,8 +111,8 @@
function="Pref.setControlFalse"
parameter="MuteAmbient" />
</slider>
<button
control_name="MuteAmbient"
<button
control_name="MuteAmbient"
disabled_control="MuteAudio"
follows="top|left"
height="16"
@ -145,7 +145,7 @@
function="Pref.setControlFalse"
parameter="MuteSounds" />
</slider>
<button
<button
control_name="MuteSounds"
disabled_control="MuteAudio"
follows="top|left"
@ -157,7 +157,10 @@
left_pad="5"
name="mute_audio"
tab_stop="false"
width="16" />
width="16">
<button.commit_callback
function="Pref.SetSounds"/>
</button>
<slider
control_name="AudioLevelMusic"
disabled_control="MuteAudio"
@ -298,7 +301,18 @@
left_pad="5"
name="enable_voice_check"
width="110"/>
<!-- -->
<check_box
name="gesture_audio_play_btn"
control_name="EnableGestureSounds"
disabled_control="MuteAudio"
value="true"
follows="left|bottom|right"
height="15"
tool_tip="Check this to hear sounds from gestures"
label="Play sounds from gestures"
top_pad="1"
bottom_delta="10"
left="325"/>
<check_box
name="media_auto_play_btn"
control_name="ParcelMediaAutoPlayEnable"
@ -309,6 +323,7 @@
tool_tip="Check this to automatically start media when you log in or change regions."
label="Allow Media to auto-play when entering a region"
top_pad="1"
bottom_delta="30"
left="25"/>
<check_box
name="media_allowscript_btn"
@ -327,7 +342,7 @@
value="true"
follows="left|bottom|right"
height="15"
bottom_delta="-0"
bottom_delta="0"
left_delta="245"
tool_tip="Check this to enable the filter that allows you to choose whether to play media from a specific host"
label="Enable media filter (increased security)"
@ -366,7 +381,7 @@
left="25"
name="voice_chat_settings"
width="180"
top_pad="40">
top_pad="35">
Voice Chat Settings
</text>
<text