From 6d1d0ebb2276d276fba375856c99007d6ad7b006 Mon Sep 17 00:00:00 2001 From: Zi Ree Date: Tue, 6 Aug 2024 19:38:27 +0200 Subject: [PATCH] FIRE-34344 - add safeguard for string to longlong conversion against 0 pointer --- indra/media_plugins/cef/linux_volume_catcher.cpp | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/indra/media_plugins/cef/linux_volume_catcher.cpp b/indra/media_plugins/cef/linux_volume_catcher.cpp index bc1fb38af0..b7dbb02f2c 100755 --- a/indra/media_plugins/cef/linux_volume_catcher.cpp +++ b/indra/media_plugins/cef/linux_volume_catcher.cpp @@ -399,7 +399,13 @@ void callback_discovered_sinkinput(pa_context *context, const pa_sink_input_info if (0 == eol) { pa_proplist *proplist = sii->proplist; - pid_t sinkpid = atoll(llpa_proplist_gets(proplist, PA_PROP_APPLICATION_PROCESS_ID)); + const char* str = llpa_proplist_gets(proplist, PA_PROP_APPLICATION_PROCESS_ID); + if (!str) + { + return; + } + + pid_t sinkpid = atoll(str); if (isPluginPid( sinkpid )) // does the discovered sinkinput belong to this process? {