livie
/
phoenix-firestorm
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MAINT-7634: Feedback from code review, move enum to string converter to own function.

master
Rider Linden 2017-08-14 14:54:58 -07:00
parent 1038633526
commit 79856e6554
2 changed files with 23 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
indra/llcorehttp/_httpoprequest.cpp
View File

@ -247,24 +247,7 @@ void HttpOpRequest::visitNotifier(HttpRequest * request)
response->setHeaders(mReplyHeaders);
response->setRequestURL(mReqURL);
std::string method("UNKNOWN");
if (mReqMethod == HOR_COPY)
method = "COPY";
else if (mReqMethod == HOR_DELETE)
method = "DELETE";
else if (mReqMethod == HOR_GET)
method = "GET";
else if (mReqMethod == HOR_MOVE)
method = "MOVE";
else if (mReqMethod == HOR_PATCH)
method = "PATCH";
else if (mReqMethod == HOR_POST)
method = "POST";
else if (mReqMethod == HOR_PUT)
method = "PUT";
response->setRequestMethod(method);
response->setRequestMethod(methodToString(mReqMethod));
if (mReplyOffset || mReplyLength)
{
@ -1161,6 +1144,25 @@ int HttpOpRequest::debugCallback(CURL * handle, curl_infotype info, char * buffe
return 0;
}
std::string HttpOpRequest::methodToString(const HttpOpRequest::EMethod &e)
{
if (e == HOR_COPY)
return "COPY";
else if (e == HOR_DELETE)
return "DELETE";
else if (e == HOR_GET)
return "GET";
else if (e == HOR_MOVE)
return "MOVE";
else if (e == HOR_PATCH)
return "PATCH";
else if (e == HOR_POST)
return "POST";
else if (e == HOR_PUT)
return "PUT";
return "UNKNOWN";
}
} // end namespace LLCore

4
indra/llcorehttp/_httpoprequest.h
View File

@ -87,7 +87,8 @@ public:
HOR_COPY,
HOR_MOVE
};
static std::string methodToString(const EMethod &);
virtual void stageFromRequest(HttpService *);
virtual void stageFromReady(HttpService *);
virtual void stageFromActive(HttpService *);
@ -235,6 +236,7 @@ public:
}; // end class HttpOpRequest
/// HttpOpRequestCompare isn't an operation but a uniform comparison
/// functor for STL containers that order by priority. Mainly
/// used for the ready queue container but defined here.