FIRE-11866: 'Environment' button no longer working in StarLight and StarLightCUI skins

+ small cleanup in MetaHarper

indra/newview/skins/metaharper/xui/en/panel_navigation_bar.xml

@@ -134,11 +134,7 @@
 	     label="Sky" 
 	     tool_tip="Pops up Sky Editor window"
 	     top_delta="0"
-	     width="30">
-		 <button.commit_callback
-               function="World.EnvPreset"
-               parameter="edit_sky" />
-		 </button>
+	     width="30" />
           <!-- end of Windlight Button -->
 
 	</layout_panel>

indra/newview/skins/starlight/xui/en/panel_navigation_bar.xml

@@ -139,9 +139,9 @@
 	     tool_tip="Pops up Environment Settings window"
 	     top_delta="0"
 	     width="38">
-		 <button.commit_callback
-               function="World.EnvSettings"
-               parameter="editor" />
+		 <button.init_callback
+               function="Button.SetFloaterToggle"
+               parameter="env_settings" />
 		 </button>
           <!-- end of Windlight Button -->
 

indra/newview/skins/starlightcui/xui/en/panel_navigation_bar.xml

@@ -138,9 +138,9 @@
 	     tool_tip="Pops up Environment Settings window"
 	     top_delta="0"
 	     width="38">
-		 <button.commit_callback
-               function="World.EnvSettings"
-               parameter="editor" />
+		 <button.init_callback
+               function="Button.SetFloaterToggle"
+               parameter="env_settings" />
 		 </button>
           <!-- end of Windlight Button -->