Do not bit blast 0 into a non POD struct to zero it, rather use the default constructor.

There is a few peculiar differences in default member initializationn namely:
gamma > 1.0f; sun_norm > 0.0f, 1.0f, 0.0f, 1.0f; cloud_shadow > 1.0f; dome_radius > 1.0f; dome_offset > 1.0f
Which probably made the original memset produce the wrong result anyway as it differs from the value the
LLVOSky set (the default ctor of AtmosphericsVars) vs what the memset would produce in case of a force update (all 0s).
master
Nicky 2022-02-12 18:47:31 +01:00
parent af610f4ad8
commit 84ca1a3c7a
1 changed files with 1 additions and 3 deletions

View File

@ -680,9 +680,7 @@ void LLVOSky::idleUpdate(LLAgent &agent, const F64 &time)
void LLVOSky::forceSkyUpdate()
{
mForceUpdate = TRUE;
memset(&m_lastAtmosphericsVars, 0x00, sizeof(AtmosphericsVars));
m_lastAtmosphericsVars = {};
mCubeMapUpdateStage = -1;
}