From 876f7f48bb7b341e84c27b56fc8cfce8e1754372 Mon Sep 17 00:00:00 2001 From: Andrey Kleshchev Date: Mon, 12 Oct 2020 22:24:46 +0300 Subject: [PATCH] SL-13980 Crash at cullAvatarsByPixelArea LLVOAvatars and derived classes appear to be stored as LLPointer in a lot of cases, so non-virtual ~LLViewerObject() might be triggered by LLPointer and end up not cleaning sInstances in some cases (animeshes specific?), thus causing broken pointers in sInstances. --- indra/newview/llviewerobject.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/indra/newview/llviewerobject.h b/indra/newview/llviewerobject.h index 57ddb8b611..07498bec2b 100644 --- a/indra/newview/llviewerobject.h +++ b/indra/newview/llviewerobject.h @@ -116,7 +116,7 @@ class LLViewerObject public LLTrace::MemTrackable { protected: - ~LLViewerObject(); // use unref() + virtual ~LLViewerObject(); // use unref() // TomY: Provide for a list of extra parameter structures, mapped by structure name struct ExtraParameter