From 9baa80eb6abc8d6802d72d540ec287c986f53a84 Mon Sep 17 00:00:00 2001 From: Arrehn Date: Sun, 17 Apr 2011 23:12:01 -0400 Subject: [PATCH] FIRE-716, When showing displayname/username , only show username if display name != legacy name, by Ansariel Hiller --- indra/llcommon/llavatarname.cpp | 10 ++++++---- indra/newview/llchathistory.cpp | 2 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/indra/llcommon/llavatarname.cpp b/indra/llcommon/llavatarname.cpp index ad1845d387..ba3dd6d6b4 100644 --- a/indra/llcommon/llavatarname.cpp +++ b/indra/llcommon/llavatarname.cpp @@ -90,14 +90,16 @@ void LLAvatarName::fromLLSD(const LLSD& sd) std::string LLAvatarName::getCompleteName() const { std::string name; - if (!mUsername.empty()) + if (mUsername.empty() || mIsDisplayNameDefault) + // If the display name feature is off + // OR this particular display name is defaulted (i.e. based on user name), + // then display only the easier to read instance of the person's name. { - name = mDisplayName + " (" + mUsername + ")"; + name = mDisplayName; } else { - // ...display names are off, legacy name is in mDisplayName - name = mDisplayName; + name = mDisplayName + " (" + mUsername + ")"; } return name; } diff --git a/indra/newview/llchathistory.cpp b/indra/newview/llchathistory.cpp index 0fe4c17eab..4e79590a25 100644 --- a/indra/newview/llchathistory.cpp +++ b/indra/newview/llchathistory.cpp @@ -717,7 +717,7 @@ void LLChatHistory::clear() void LLChatHistory::onAvatarNameCache(const LLUUID& agent_id, const LLAvatarName& av_name) { mDisplayName = av_name.mDisplayName; - mDisplayName_Username = mDisplayName + " ("+av_name.mUsername+")"; + mDisplayName_Username = av_name.getCompleteName(); } //-TT Display names timing in chat