livie
/
phoenix-firestorm
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Continue keeping built-in audio effects disabled - only disable duplicate call to updateDevices() which is already called via 

LLWebRTCVoiceClient::initWebRTC() -> LLWebRTCVoiceClient::refreshDeviceLists() -> LLWebRTCImpl::refreshDevices()

and duplicate to

LLWebRTCVoiceClient::initWebRTC() -> llwebrtc::init() -> LLWebRTCImpl::init()
master
Ansariel 2025-10-18 12:26:47 +02:00
parent 4a6975a944
commit 9fe6e65aed
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
indra/llwebrtc/llwebrtc.cpp
View File

@ -339,22 +339,20 @@ void LLWebRTCImpl::init()
nullptr /* video_decoder_factory */,
nullptr /* audio_mixer */,
mAudioProcessingModule);
// <FS:minerjr> [FIRE-36022] - Removing my USB headset crashes entire viewer
// It seems that this code is also called by one of the other callback functions
// and ends up creating a 2nd observer,which when there was a hardware change,
// would cause multiple messages to be dumped to the queue at the same time and
// cause a possible race condition/spin lock issue.
/* mWorkerThread->PostTask(
mWorkerThread->PostTask(
[this]()
{
if (mDeviceModule)
{
mDeviceModule->EnableBuiltInAEC(false);
updateDevices();
// <FS:minerjr> [FIRE-36022] - Removing my USB headset crashes entire viewer
// It seems that this code is also called by one of the other callback functions
// and ends up creating a 2nd observer,which when there was a hardware change,
// would cause multiple messages to be dumped to the queue at the same time and
// cause a possible race condition/spin lock issue.
//updateDevices();
}
});
*/
// </FS:minerjr> [FIRE-36022]
}
void LLWebRTCImpl::terminate()