From acae30fd287209583c745a6c88b8ca90e12e8e59 Mon Sep 17 00:00:00 2001 From: Beq Date: Mon, 2 Sep 2024 17:39:41 +0100 Subject: [PATCH] Added node-dump-syms installation for Linux In the GitHub workflow, a step has been added to install node-dump-syms when the runner OS is Linux. Also, the file path for Windows in Post Bugsplat Symbols has been updated to specifically target Release files. --- .github/workflows/build_viewer.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build_viewer.yml b/.github/workflows/build_viewer.yml index 6ebbf84442..f8f01b170e 100644 --- a/.github/workflows/build_viewer.yml +++ b/.github/workflows/build_viewer.yml @@ -304,6 +304,9 @@ jobs: echo "viewer_build=$viewer_build" >> "$GITHUB_OUTPUT" echo "viewer_channel=${{ env.FS_RELEASE_CHAN }}" >> "$GITHUB_OUTPUT" echo "viewer_release_type=${{ env.FS_RELEASE_TYPE }}" >> "$GITHUB_OUTPUT" + - name: Install node-dump-syms + if: runner.os == 'Linux' + run: npm install -g @bugsplat/node-dump-syms - name: Post Bugsplat Symbols uses: beqjanus/symbol-upload@main with: @@ -312,7 +315,7 @@ jobs: database: ${{ steps.version.viewer_release_type == 'Release' && secrets.BUGSPLAT_RELEASE_DB || secrets.BUGSPLAT_PREVIEW_DB }} application: "Firestorm-${{ steps.version.outputs.viewer_channel}}" version: ${{ steps.version.outputs.viewer_version }}.${{ steps.version.outputs.viewer_build }} - files: ${{ runner.os == 'Windows' && '**/*.{pdb,exe,dll}' || runner.os == 'macOS' && '**/*.xcarchive.zip' || '**/{do-not-run-directly-firestorm-bin,*.sym}' }} + files: ${{ runner.os == 'Windows' && '**/Release/*.{pdb,exe,dll}' || runner.os == 'macOS' && '**/*.xcarchive.zip' || '**/{do-not-run-directly-firestorm-bin,*.sym}' }} directory: "build-*" node-version: "20" dumpSyms: ${{ runner.os == 'Linux' && 'true' || 'false' }}