From aeebb452e698d8aaa7a01b49c20b2f0b7cfc1a3b Mon Sep 17 00:00:00 2001 From: Nat Goodspeed Date: Fri, 28 Jun 2019 16:12:46 -0400 Subject: [PATCH] DRTVWR-476: Disable test_httprequest.hpp on Mac Release builds. For reasons not yet diagnosed, specifically in Mac Release builds, the tests in test_httprequest.hpp consistently crash with a backtrace suggesting that the worker thread is calling LLCore::HttpLibcurl::completeRequest() after the foreground thread calls HttpRequest::destroyService(). Weirdly, even executing a tut::skip() call in every test() function up to the point of the crash does not eliminate the crash. --- indra/llcorehttp/tests/llcorehttp_test.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/indra/llcorehttp/tests/llcorehttp_test.cpp b/indra/llcorehttp/tests/llcorehttp_test.cpp index cf4dff877a..362b2309ee 100755 --- a/indra/llcorehttp/tests/llcorehttp_test.cpp +++ b/indra/llcorehttp/tests/llcorehttp_test.cpp @@ -41,9 +41,14 @@ #include "test_httpstatus.hpp" #include "test_refcounted.hpp" #include "test_httpoperation.hpp" +// As of 2019-06-28, test_httprequest.hpp consistently crashes on Mac Release +// builds for reasons not yet diagnosed. +#if ! (LL_DARWIN && LL_RELEASE) #include "test_httprequest.hpp" +#endif #include "test_httpheaders.hpp" #include "test_httprequestqueue.hpp" +#include "_httpservice.h" #include "llproxy.h" #include "llcleanup.h"