From bc4bf9e207ebe02bae99efab5d3ce2874db055f2 Mon Sep 17 00:00:00 2001 From: RunitaiLinden Date: Wed, 24 Jan 2024 12:30:45 -0600 Subject: [PATCH 01/15] Create bug.yaml --- .github/ISSUE_TEMPLATE/bug.yaml | 36 +++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/bug.yaml diff --git a/.github/ISSUE_TEMPLATE/bug.yaml b/.github/ISSUE_TEMPLATE/bug.yaml new file mode 100644 index 0000000000..224a5bbde6 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug.yaml @@ -0,0 +1,36 @@ +name: Bug report +description: Viewer bug report +labels: [bug] +body: +- type: markdown + attributes: + value: | + - Write a descriptive bug title above. + - Search [open](https://github.com/secondlife/viewer/issues?q=is%3Aopen+label%3Abug+is%3Aissue) bugs to ensure that the issue has not already been identified. + +- type: textarea + attributes: + label: Environment + description: About Second Life Text + placeholder: ex. Second Life Test 7.1.3.240191747 (64bit) ... + validations: + required: true + +- type: textarea + attributes: + label: Description + description: Explain the problem. + validations: + required: true + +- type: textarea + attributes: + label: Reproduction steps + description: Steps to reproduce this bug + placeholder: | + 1. First step + 2. Second step + Expected: ... + Actual: ... + validations: + required: true From cb14e9a074ef415d7856a2067edec7b88570bf9e Mon Sep 17 00:00:00 2001 From: RunitaiLinden Date: Wed, 24 Jan 2024 12:32:10 -0600 Subject: [PATCH 02/15] Create enhancement.md --- .github/ISSUE_TEMPLATE/enhancement.md | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/enhancement.md diff --git a/.github/ISSUE_TEMPLATE/enhancement.md b/.github/ISSUE_TEMPLATE/enhancement.md new file mode 100644 index 0000000000..dbb6f4601d --- /dev/null +++ b/.github/ISSUE_TEMPLATE/enhancement.md @@ -0,0 +1,12 @@ +--- +name: Enhancement +about: New feature or enhancement +title: New Feature +labels: enhancement +--- + +_What does this feature/enhancement do? Why is it needed?_ + +## Test Plan + +_Include information, such as guidance and test scenarios, QA will need to test this feature._ From 10947104db41fc6fa71f4f8432e8523747d4e5e6 Mon Sep 17 00:00:00 2001 From: Bennett Goble Date: Fri, 26 Jan 2024 15:54:38 -0800 Subject: [PATCH 03/15] Add a basic CONTRIBUTING.md Provide basic instructions in-repository for contributing to Second Life. --- CONTRIBUTING.md | 76 +++++++++++++++++++++++++++++++++++++++++++++++++ README.md | 3 +- 2 files changed, 78 insertions(+), 1 deletion(-) create mode 100644 CONTRIBUTING.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md new file mode 100644 index 0000000000..6bd8a2b74c --- /dev/null +++ b/CONTRIBUTING.md @@ -0,0 +1,76 @@ +# Contributor guidelines + +Thanks for your interest in contributing to Second Life! This document +summarizes some of the most important points for people looking to contribute +to the platform especially those looking to provide bug reports and code +changes. + +## Table of contents + +- [Communication](#communication) +- [Reporting bugs and requesting features](#reporting-bugs-and-requesting-features) +- [Contributing pull requests](#contributing-pull-requests) + +## Communication + +Second Life has multiple channels for communication. Some of these channels are +more end-user focused, while others are more tailored for +developer-to-developer or support. + +- [feedback.secondlife.com][] is Second Life's primary community engagement + forum. Ideas and bug reports should be placed here unless they relate to + ongoing development issues and developer-to-developer communication. +- [Public user groups][slug] are held on a regular basis, including those for + discussing open source development, content creation, server topics and more. +- [Github issues][] provide a means for staff to organize their + work and collaborate with other developers. By default most user-facing + discussions should happen on [feedback.secondlife.com][] so that they are + visible to more people, can build consensus, and be placed onto our public + roadmap. Github issues are useful for collaboration between viewer forks + and the official upstream and when engineering-specific and technical + collaboration is beneficial. +- [Official forums][] exist for many topics including content creation, + scripting, social topics and more. +- The [opensource-dev mailing list][] is useful for announcements and + discussion between viewer maintainers. + + +## Reporting bugs and requesting features + +Report bugs and provide ideas for features using the respective board on Second +Life's feedback portal: + +- [Features](https://feedback.secondlife.com/feature-requests) +- [Scripting bugs](https://feedback.secondlife.com/scripting-bugs) +- [Scripting features](https://feedback.secondlife.com/scripting-features) +- [Server bugs](https://feedback.secondlife.com/scripting-bugs) +- [Viewer bugs](https://feedback.secondlife.com/bug-reports) +- [Web/Marketplace bugs](https://feedback.secondlife.com/web-bugs) +- [Web/Marketplace features](https://feedback.secondlife.com/web-features) + +Creating posts on feedback.secondlife.com is important as it allows the greatest +exposure and input from Second Life users. It also allows Linden Lab staff to +place work on a single public roadmap. + +Issues created on feedback.secondlife.com are imported onto Github after they +have been reviewed by staff and accepted. + +## Contributing pull requests + +If you wish to contribute a new pull request, please ensure that: + +- You talk to other developers about how best to implement the work. +- The functionality is desired. Be sure to talk to users and Second Life staff to ensure + the work is a good idea and will be accepted. +- The work is high quality and the PR follows [PR etiquette][] +- You have tested the work locally + +The [Git Style Guide](https://github.com/agis/git-style-guide) is also a good +reference for best git practices. + +[feedback.secondlife.com]: https://feedback.secondlife.com +[slug]: https://community.secondlife.com/blogs/entry/6509-introducing-the-second-life-public-calendar/ +[PR etiquette]: https://gist.github.com/mikepea/863f63d6e37281e329f8 +[Github issues]: https://github.com/secondlife/viewer/issues +[Official forums]: https://community.secondlife.com/forums/ +[opensource-dev mailing list]: https://wiki.secondlife.com/wiki/OpenSource-Dev diff --git a/README.md b/README.md index c57140af9c..1e40c7f9f5 100644 --- a/README.md +++ b/README.md @@ -35,9 +35,10 @@ Third party maintained forks, which include Linux compatible builds, are indexed ## Contribute Help make Second Life better! You can get involved with improvements by filing bugs, suggesting enhancements, submitting -pull requests and more. See the [open source portal][] for details. +pull requests and more. See the [CONTRIBUTING][] and the [open source portal][] for details. [Second Life]: https://secondlife.com/ [download]: https://secondlife.com/support/downloads/ [tpv]: http://wiki.secondlife.com/wiki/Third_Party_Viewer_Directory [open source portal]: http://wiki.secondlife.com/wiki/Open_Source_Portal +[contributing]: https://github.com/secondlife/viewer/blob/main/CONTRIBUTING.md From a9158943a825d18d0e1146d3745ff599c91e290a Mon Sep 17 00:00:00 2001 From: Vir Linden <60274682+vir-linden@users.noreply.github.com> Date: Mon, 29 Jan 2024 12:38:11 -0500 Subject: [PATCH 04/15] Update bug.yaml --- .github/ISSUE_TEMPLATE/bug.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/bug.yaml b/.github/ISSUE_TEMPLATE/bug.yaml index 224a5bbde6..41208e8bf5 100644 --- a/.github/ISSUE_TEMPLATE/bug.yaml +++ b/.github/ISSUE_TEMPLATE/bug.yaml @@ -1,6 +1,6 @@ name: Bug report description: Viewer bug report -labels: [bug] +labels: [bug, triage] body: - type: markdown attributes: From 00962fd397655ac60bff0a352624243c2b22c266 Mon Sep 17 00:00:00 2001 From: Vir Linden <60274682+vir-linden@users.noreply.github.com> Date: Mon, 29 Jan 2024 12:42:28 -0500 Subject: [PATCH 05/15] Update enhancement.md --- .github/ISSUE_TEMPLATE/enhancement.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/enhancement.md b/.github/ISSUE_TEMPLATE/enhancement.md index dbb6f4601d..dd40478811 100644 --- a/.github/ISSUE_TEMPLATE/enhancement.md +++ b/.github/ISSUE_TEMPLATE/enhancement.md @@ -2,7 +2,7 @@ name: Enhancement about: New feature or enhancement title: New Feature -labels: enhancement +labels: enhancement, triage --- _What does this feature/enhancement do? Why is it needed?_ From 27e3fdc957cba70645f9c6edf8ac994305116e6c Mon Sep 17 00:00:00 2001 From: Bennett Goble Date: Tue, 30 Jan 2024 08:50:33 -0800 Subject: [PATCH 06/15] build.yaml: Build shared branches We're currently building every single commit pushed to Github. This is racking up $20k in build charges a month and is generally superfluous. This changeset alters build triggers so that builds automatically run if they are committed to a **shared branch**: - `release/*` - A release stabilization branch - `project/*` - A project viewer branch - `main/*` - The default/stable branch PR commits are also automatically built. ...need to build another commit? Developers can trigger one using a manual workflow run. --- .github/workflows/build.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 849c10d62e..1dd2c1d5df 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -4,8 +4,8 @@ on: workflow_dispatch: pull_request: push: - branches: ["*"] - tags: ["*"] + branches: ["main", "release/*", "project/*"] + tags: ["Second_Life_*"] jobs: build: From 95f213115bab14691cd9c00268a7deb91dc0f746 Mon Sep 17 00:00:00 2001 From: Signal Linden Date: Mon, 5 Feb 2024 16:09:54 -0800 Subject: [PATCH 07/15] Add link to feedback portal Provide a link to feedback.secondlife.com from the issue creation page. --- .github/ISSUE_TEMPLATE/config.yaml | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/config.yaml diff --git a/.github/ISSUE_TEMPLATE/config.yaml b/.github/ISSUE_TEMPLATE/config.yaml new file mode 100644 index 0000000000..75fa187132 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/config.yaml @@ -0,0 +1,4 @@ +contact_links: +- name: 💬 Community Feedback (Canny) + url: https://feedback.secondlife.com + about: Space for discussing and reviewing user-impacting bug reports and feature requests. From 9b51fee9bcf2529c0545316e4885f58a90bf268e Mon Sep 17 00:00:00 2001 From: Signal Linden Date: Wed, 7 Feb 2024 13:24:35 -0800 Subject: [PATCH 08/15] Rename config.yaml to config.yml Issue template configuration is the only github configuration file I've found which does not support both `*.yaml` and `*.yml` extensions. Drat. --- .github/ISSUE_TEMPLATE/{config.yaml => config.yml} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/ISSUE_TEMPLATE/{config.yaml => config.yml} (100%) diff --git a/.github/ISSUE_TEMPLATE/config.yaml b/.github/ISSUE_TEMPLATE/config.yml similarity index 100% rename from .github/ISSUE_TEMPLATE/config.yaml rename to .github/ISSUE_TEMPLATE/config.yml From 255bb8504d6191358bd94e838d2f9e5360577128 Mon Sep 17 00:00:00 2001 From: Brad Linden <46733234+brad-linden@users.noreply.github.com> Date: Wed, 14 Feb 2024 09:54:46 -0800 Subject: [PATCH 09/15] Update cla.yaml allowlist to clear spurious errors (#804) --- .github/workflows/cla.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/cla.yaml b/.github/workflows/cla.yaml index fa180c66c9..b4b2565889 100644 --- a/.github/workflows/cla.yaml +++ b/.github/workflows/cla.yaml @@ -23,3 +23,4 @@ jobs: path-to-signatures: signatures.json remote-organization-name: secondlife remote-repository-name: cla-signatures + allowlist: callum@mbp.localdomain From 4b24b0d933fa701720d876639d2bbdd9b834b725 Mon Sep 17 00:00:00 2001 From: Vir Linden <60274682+vir-linden@users.noreply.github.com> Date: Thu, 22 Feb 2024 10:28:10 -0500 Subject: [PATCH 10/15] Create issue_template.md Issue template for the "blank issue" option --- .github/ISSUE_TEMPLATE/issue_template.md | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/issue_template.md diff --git a/.github/ISSUE_TEMPLATE/issue_template.md b/.github/ISSUE_TEMPLATE/issue_template.md new file mode 100644 index 0000000000..96e71e64f5 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/issue_template.md @@ -0,0 +1,3 @@ +--- +labels: triage +--- From e452eeb81685b82581b7a3893b4cdbf0546a401c Mon Sep 17 00:00:00 2001 From: Vir Linden <60274682+vir-linden@users.noreply.github.com> Date: Thu, 22 Feb 2024 11:24:55 -0500 Subject: [PATCH 11/15] Update issue_template.md --- .github/ISSUE_TEMPLATE/issue_template.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/issue_template.md b/.github/ISSUE_TEMPLATE/issue_template.md index 96e71e64f5..b78a5f7774 100644 --- a/.github/ISSUE_TEMPLATE/issue_template.md +++ b/.github/ISSUE_TEMPLATE/issue_template.md @@ -1,3 +1,5 @@ --- +name: default issue +description: template for default new issue if no template is selected labels: triage --- From b9ac5e843331e34d9ec64ae60c4d2fef2994d3a7 Mon Sep 17 00:00:00 2001 From: Vir Linden <60274682+vir-linden@users.noreply.github.com> Date: Thu, 22 Feb 2024 11:26:54 -0500 Subject: [PATCH 12/15] Update issue_template.md --- .github/ISSUE_TEMPLATE/issue_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/issue_template.md b/.github/ISSUE_TEMPLATE/issue_template.md index b78a5f7774..0a106ca1e2 100644 --- a/.github/ISSUE_TEMPLATE/issue_template.md +++ b/.github/ISSUE_TEMPLATE/issue_template.md @@ -1,5 +1,5 @@ --- name: default issue -description: template for default new issue if no template is selected +about: template for default new issue if no template is selected labels: triage --- From ffef19843b79c53aa710ed475d526f0d8f91866b Mon Sep 17 00:00:00 2001 From: Vir Linden <60274682+vir-linden@users.noreply.github.com> Date: Thu, 22 Feb 2024 11:28:44 -0500 Subject: [PATCH 13/15] Delete .github/ISSUE_TEMPLATE/issue_template.md --- .github/ISSUE_TEMPLATE/issue_template.md | 5 ----- 1 file changed, 5 deletions(-) delete mode 100644 .github/ISSUE_TEMPLATE/issue_template.md diff --git a/.github/ISSUE_TEMPLATE/issue_template.md b/.github/ISSUE_TEMPLATE/issue_template.md deleted file mode 100644 index 0a106ca1e2..0000000000 --- a/.github/ISSUE_TEMPLATE/issue_template.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -name: default issue -about: template for default new issue if no template is selected -labels: triage ---- From 0f2248ea12713822c546e362487aa94bb29e2899 Mon Sep 17 00:00:00 2001 From: Brad Linden <46733234+brad-linden@users.noreply.github.com> Date: Thu, 22 Feb 2024 13:01:49 -0800 Subject: [PATCH 14/15] Improving issue templates. (#877) making ordering explicit, and disabling blank issue submission to force triage label to be set. --- .github/ISSUE_TEMPLATE/{bug.yaml => 10-bug.yaml} | 0 .../{enhancement.md => 20-enhancement.md} | 0 .github/ISSUE_TEMPLATE/30-blank.yaml | 10 ++++++++++ .github/ISSUE_TEMPLATE/config.yml | 1 + 4 files changed, 11 insertions(+) rename .github/ISSUE_TEMPLATE/{bug.yaml => 10-bug.yaml} (100%) rename .github/ISSUE_TEMPLATE/{enhancement.md => 20-enhancement.md} (100%) create mode 100644 .github/ISSUE_TEMPLATE/30-blank.yaml diff --git a/.github/ISSUE_TEMPLATE/bug.yaml b/.github/ISSUE_TEMPLATE/10-bug.yaml similarity index 100% rename from .github/ISSUE_TEMPLATE/bug.yaml rename to .github/ISSUE_TEMPLATE/10-bug.yaml diff --git a/.github/ISSUE_TEMPLATE/enhancement.md b/.github/ISSUE_TEMPLATE/20-enhancement.md similarity index 100% rename from .github/ISSUE_TEMPLATE/enhancement.md rename to .github/ISSUE_TEMPLATE/20-enhancement.md diff --git a/.github/ISSUE_TEMPLATE/30-blank.yaml b/.github/ISSUE_TEMPLATE/30-blank.yaml new file mode 100644 index 0000000000..abe2623378 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/30-blank.yaml @@ -0,0 +1,10 @@ +name: Blank Issue +description: Don’t see your issue here? Open a blank issue. +labels: [triage] +body: +- type: textarea + attributes: + label: Description + description: Please describe your issue. + validations: + required: true diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml index 75fa187132..f2d58f5f65 100644 --- a/.github/ISSUE_TEMPLATE/config.yml +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -1,3 +1,4 @@ +blank_issues_enabled: false contact_links: - name: 💬 Community Feedback (Canny) url: https://feedback.secondlife.com From 701d1a33bb8227aa55a71f48caeb30a453e77ee0 Mon Sep 17 00:00:00 2001 From: Nat Goodspeed Date: Fri, 1 Mar 2024 10:26:00 -0500 Subject: [PATCH 15/15] Increment viewer version to 7.1.4 following promotion of secondlife/viewer #673 --- indra/newview/VIEWER_VERSION.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/indra/newview/VIEWER_VERSION.txt b/indra/newview/VIEWER_VERSION.txt index 1996c50447..b7f8ee41e6 100644 --- a/indra/newview/VIEWER_VERSION.txt +++ b/indra/newview/VIEWER_VERSION.txt @@ -1 +1 @@ -7.1.3 +7.1.4