MAINT-387 FIXED [PUBLIC]Possible crash in llviewermenufile/upload_done_callback

- Just moved the deletion to the inspected block
2012-02-24 21:29:59 +02:00 · 2012-02-24 21:29:59 +02:00 · d356e2be0f
parent a128836ded
commit d356e2be0f
1 changed files with 3 additions and 2 deletions
--- a/indra/newview/llviewermenufile.cpp
+++ b/indra/newview/llviewermenufile.cpp
@ -949,11 +949,12 @@ void upload_done_callback(
 			args["REASON"] = std::string(LLAssetStorage::getErrorString(result));
 			LLNotificationsUtil::add("CannotUploadReason", args);
 		}
+
+		delete data;
+		data = NULL;
 	}

 	LLUploadDialog::modalUploadFinished();
-	delete data;
-	data = NULL;

 	// *NOTE: This is a pretty big hack. What this does is check the
 	// file picker if there are any more pending uploads. If so,