livie
/
phoenix-firestorm
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[FIRE-35019] - fix memory access error 

Fixed crashing issue in LLHUDText::renderText() cause by using mSourceObject without first checking to see if it is not null as the source object could be unloaded when teleporting to different sim.

Was testing going to https://maps.secondlife.com/secondlife/Blue%20Moon%20Bay/188/63/26
for hitching issue and issue was triggered.
master
minerjr 2024-12-30 14:22:50 -04:00
parent 2fbac952c5
commit debf2fc88c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
indra/newview/llhudtext.cpp
View File

@ -267,7 +267,7 @@ void LLHUDText::renderText()
// Also, only show the background if it is show all is checked, or if on highlight, only if use hover highlight is enabled.
if ((mShowBackground == SHOW_BACKGROUND_ALL ||
mShowBackground == SHOW_BACKGROUND_ONLY_HIGHLIGHTED && mbIsHighlighted && mbUseHoverHighlight) &&
mSourceObject->getAttachmentState() == 0)
(mSourceObject.notNull() && mSourceObject->getAttachmentState() == 0))
{
LLRect screen_rect;
screen_rect.setCenterAndSize(0, static_cast<S32>(lltrunc(-mBackgroundHeight / 2 + mOffsetY + mBackgroundOffsetY)),