livie
/
phoenix-firestorm
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix '1:angle_between' test failure

master
Andrey Lihatskiy 2025-04-18 01:04:51 +03:00
parent c0ecfce26d
commit f029903cd9
1 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
indra/llmath/v3dmath.h
View File

@ -278,21 +278,22 @@ inline const LLVector3d& LLVector3d::setVec(const F64* vec)
inline F64 LLVector3d::normVec()
{
F64 mag = sqrt(mdV[VX]*mdV[VX] + mdV[VY]*mdV[VY] + mdV[VZ]*mdV[VZ]);
F64 mag = (F32)sqrt(mdV[VX]*mdV[VX] + mdV[VY]*mdV[VY] + mdV[VZ]*mdV[VZ]); // This explicit cast to F32 limits the precision for numerical stability.
// Without it, Unit test "v3dmath_h" fails at "1:angle_between" on macos.
F64 oomag;
if (mag > FP_MAG_THRESHOLD)
{
oomag = 1.f/mag;
oomag = 1.0/mag;
mdV[VX] *= oomag;
mdV[VY] *= oomag;
mdV[VZ] *= oomag;
}
else
{
mdV[VX] = 0.f;
mdV[VY] = 0.f;
mdV[VZ] = 0.f;
mdV[VX] = 0.0;
mdV[VY] = 0.0;
mdV[VZ] = 0.0;
mag = 0;
}
return (mag);
@ -300,21 +301,21 @@ inline F64 LLVector3d::normVec()
inline F64 LLVector3d::normalize()
{
F64 mag = sqrt(mdV[VX]*mdV[VX] + mdV[VY]*mdV[VY] + mdV[VZ]*mdV[VZ]);
F64 mag = (F32)sqrt(mdV[VX]*mdV[VX] + mdV[VY]*mdV[VY] + mdV[VZ]*mdV[VZ]); // Same as in normVec() above.
F64 oomag;
if (mag > FP_MAG_THRESHOLD)
{
oomag = 1.f/mag;
oomag = 1.0/mag;
mdV[VX] *= oomag;
mdV[VY] *= oomag;
mdV[VZ] *= oomag;
}
else
{
mdV[VX] = 0.f;
mdV[VY] = 0.f;
mdV[VZ] = 0.f;
mdV[VX] = 0.0;
mdV[VY] = 0.0;
mdV[VZ] = 0.0;
mag = 0;
}
return (mag);