From 8f4c9db85c21094a5d6f841bf15450ca9b1fa069 Mon Sep 17 00:00:00 2001 From: Zi Ree Date: Thu, 12 May 2022 18:19:24 +0200 Subject: [PATCH 01/11] FIRE-31653: fix crash when pressing ctrl+f in group ban panel by adding search field --- indra/newview/llpanelgrouproles.cpp | 18 ++++++++++++++++++ indra/newview/llpanelgrouproles.h | 1 + .../skins/default/xui/en/panel_group_roles.xml | 14 +++++++++++++- 3 files changed, 32 insertions(+), 1 deletion(-) diff --git a/indra/newview/llpanelgrouproles.cpp b/indra/newview/llpanelgrouproles.cpp index a06217f818..689a2ec9a6 100644 --- a/indra/newview/llpanelgrouproles.cpp +++ b/indra/newview/llpanelgrouproles.cpp @@ -3182,6 +3182,7 @@ BOOL LLPanelGroupBanListSubTab::postBuildSubTab(LLView* root) mBanList->setCommitOnSelectionChange(TRUE); mBanList->setCommitCallback(onBanEntrySelect, this); + mBanList->setFilterColumn(0); // FIRE-31653: add banlist filter editor mCreateBanButton->setClickedCallback(onCreateBanEntry, this); mCreateBanButton->setEnabled(FALSE); @@ -3260,6 +3261,13 @@ void LLPanelGroupBanListSubTab::onBanEntrySelect(LLUICtrl* ctrl, void* user_data void LLPanelGroupBanListSubTab::handleBanEntrySelect() { + // FIRE-31653: disable remove ban button when no entry is selected + if (!mBanList->getNumSelected()) + { + mDeleteBanButton->setEnabled(false); + return; + } + // if (gAgent.hasPowerInGroup(mGroupID, GP_GROUP_BAN_ACCESS)) { mDeleteBanButton->setEnabled(TRUE); @@ -3434,3 +3442,13 @@ void LLPanelGroupBanListSubTab::setGroupID(const LLUUID& id) setFooterEnabled(FALSE); LLPanelGroupSubTab::setGroupID(id); } + +// FIRE-31653: add banlist filter editor +void LLPanelGroupBanListSubTab::onFilterChanged() +{ + mBanList->setFilterString(mSearchFilter); + + // disable remove ban button as a change of filter will deselect all entries + mDeleteBanButton->setEnabled(false); +} +// add banlist filter editor diff --git a/indra/newview/llpanelgrouproles.h b/indra/newview/llpanelgrouproles.h index 0bee64bce3..9d5df28f4d 100644 --- a/indra/newview/llpanelgrouproles.h +++ b/indra/newview/llpanelgrouproles.h @@ -357,6 +357,7 @@ public: virtual void activate(); virtual void update(LLGroupChange gc); + virtual void onFilterChanged(); // FIRE-31653: add banlist filter editor virtual void draw(); static void onBanEntrySelect(LLUICtrl* ctrl, void* user_data); diff --git a/indra/newview/skins/default/xui/en/panel_group_roles.xml b/indra/newview/skins/default/xui/en/panel_group_roles.xml index ff1d782b1e..0b6a9bf2e0 100644 --- a/indra/newview/skins/default/xui/en/panel_group_roles.xml +++ b/indra/newview/skins/default/xui/en/panel_group_roles.xml @@ -360,10 +360,22 @@ things in this group. There's a broad variety of Abilities. name="ban_count_template"> Ban count: [COUNT]/[LIMIT] + + + Date: Thu, 12 May 2022 22:36:39 +0200 Subject: [PATCH 02/11] Update German translation --- indra/newview/skins/default/xui/de/panel_group_roles.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/indra/newview/skins/default/xui/de/panel_group_roles.xml b/indra/newview/skins/default/xui/de/panel_group_roles.xml index 317708aef9..4c6c7bbd11 100644 --- a/indra/newview/skins/default/xui/de/panel_group_roles.xml +++ b/indra/newview/skins/default/xui/de/panel_group_roles.xml @@ -74,6 +74,7 @@ Rechte in einer Gruppe. Es gibt viele verschiedene Fähigkeiten. Bann-Anzahl: [COUNT]/[LIMIT] + From 3223bb7906ac19155a1fe4a77c2ec7d827390047 Mon Sep 17 00:00:00 2001 From: PanteraPolnocy Date: Sun, 15 May 2022 00:06:02 +0200 Subject: [PATCH 03/11] FIRE-31657: Ban filter translation update, for Russian (by Romka Swallowtail) and Polish --- indra/newview/skins/default/xui/pl/panel_group_roles.xml | 1 + indra/newview/skins/default/xui/ru/panel_group_roles.xml | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/indra/newview/skins/default/xui/pl/panel_group_roles.xml b/indra/newview/skins/default/xui/pl/panel_group_roles.xml index 424f1f54a5..967be38166 100644 --- a/indra/newview/skins/default/xui/pl/panel_group_roles.xml +++ b/indra/newview/skins/default/xui/pl/panel_group_roles.xml @@ -57,6 +57,7 @@ na wykonywanie różnych zadań. Istnieje wiele przywilejów. Bany: [COUNT]/[LIMIT] + diff --git a/indra/newview/skins/default/xui/ru/panel_group_roles.xml b/indra/newview/skins/default/xui/ru/panel_group_roles.xml index 9cc1875408..22c493ffbb 100644 --- a/indra/newview/skins/default/xui/ru/panel_group_roles.xml +++ b/indra/newview/skins/default/xui/ru/panel_group_roles.xml @@ -58,8 +58,9 @@ Забанено: [COUNT]/[LIMIT] + - +