From fc66d0841616f2abbda2e7ea08e62d39cb2df0c2 Mon Sep 17 00:00:00 2001
From: Kitty Barnett <develop@catznip.com>
Date: Sat, 13 Feb 2021 19:16:42 +0100
Subject: [PATCH] [FIXED] GCC and Clang warnings and error

---
 indra/newview/llvisualeffect.h | 10 ++--------
 indra/newview/rlveffects.cpp   |  2 ++
 indra/newview/rlvhelper.cpp    |  2 +-
 3 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/indra/newview/llvisualeffect.h b/indra/newview/llvisualeffect.h
index fb11881e21..0bceec5fbb 100644
--- a/indra/newview/llvisualeffect.h
+++ b/indra/newview/llvisualeffect.h
@@ -89,12 +89,6 @@ protected:
 //
 //
 
-enum class LLTweenType
-{
-	None,
-	Lerp,
-};
-
 template<typename T>
 class LLTweenableValue
 {
@@ -118,13 +112,13 @@ template<typename T>
 class LLTweenableValueLerp : public LLTweenableValue<T>
 {
 public:
-	LLTweenableValueLerp(const T& defaultValue) : LLTweenableValue(defaultValue) {}
+	LLTweenableValueLerp(const T& defaultValue) : LLTweenableValue<T>(defaultValue) {}
 
 	T    get() override;
 	void start(const T& endValue, double duration) override
 	{
 		m_StartValue = get();
-		m_CurValue = boost::none;
+		this->m_CurValue = boost::none;
 		m_EndValue = endValue;
 
 		m_StartTime = LLTimer::getElapsedSeconds();
diff --git a/indra/newview/rlveffects.cpp b/indra/newview/rlveffects.cpp
index 9ed13747ba..6da6a15825 100644
--- a/indra/newview/rlveffects.cpp
+++ b/indra/newview/rlveffects.cpp
@@ -433,6 +433,8 @@ void RlvSphereEffect::run(const LLVisualEffectParams* pParams)
 			gRlvSphereProgram.uniform2f(LLShaderMgr::RLV_EFFECT_PARAM5, 0.f, 1.f);
 			renderPass(&gRlvSphereProgram, pShaderParams);
 			break;
+		default:
+			llassert(true);
 	}
 
 	gRlvSphereProgram.unbind();
diff --git a/indra/newview/rlvhelper.cpp b/indra/newview/rlvhelper.cpp
index c7eb508a53..70c5ac4819 100644
--- a/indra/newview/rlvhelper.cpp
+++ b/indra/newview/rlvhelper.cpp
@@ -412,7 +412,7 @@ const RlvBehaviourInfo* RlvBehaviourDictionary::getBehaviourInfo(ERlvBehaviour e
 {
 	const RlvBehaviourInfo* pBhvrInfo = nullptr;
 	for (auto itBhvrLower = m_Bhvr2InfoMap.lower_bound(eBhvr), itBhvrUpper = m_Bhvr2InfoMap.upper_bound(eBhvr);
-		 std::find_if(itBhvrLower, itBhvrUpper, [eBhvr, eParamType](const rlv_bhvr2info_map_t::value_type& bhvrEntry) { return bhvrEntry.second->getParamTypeMask() == eParamType; }) != itBhvrUpper;
+		 std::find_if(itBhvrLower, itBhvrUpper, [eParamType](const rlv_bhvr2info_map_t::value_type& bhvrEntry) { return bhvrEntry.second->getParamTypeMask() == eParamType; }) != itBhvrUpper;
 		++itBhvrLower)
 	{
 		if (pBhvrInfo)