Commit Graph

5 Commits (1d4d4fec00aacb1e1e00a4f60a6af4d8ed3b8bde)

Author SHA1 Message Date
Rick Pasetto 628e10b080 "Fix" unit test: you can't count on timers being scheduled to not actually also fire in the same 'pump' 2009-10-13 19:56:38 -07:00
Rick Pasetto d9c1237e6f Disable boost::lexical_cast warning 2009-10-13 16:35:49 -07:00
Rick Pasetto 630e003347 Potential fix for unit test (though I can't run it :( ) 2009-10-13 13:05:19 -07:00
palange dbe7135cc4 merge of login-api 2009-10-12 19:03:52 -04:00
Rick Pasetto d4b2897700 Unit tests for LLMediaDataClient
This required a bit of refactoring of LLMediaDataClient:
- Created LLMediaDataClientObject ABC, which now has a
  concrete impl in LLVOVolume
- Created unit test with 6 tests (for now), testing
  - LLObjectMediaDataClient::fetchMedia()
  - LLObjectMediaDataClient::updateMedia()
  - LLObjectMediaNavigateClient::navigate()
  - queue ordering
  - retries
  - nav bounce back
- Also ensures that ref counting works properly (this is important, because
  ownership is tricky with smart pointers put into queues, peeled off
  into timers that fire and auto destruct, and HTTP responders that also
  auto-destruct)
- Had to fix LLCurl::Responder's stub, which was not initializing
  the ref count to 0, causing the ref counting tests to fail
  (boy, that was hard to find!).

Reviewed by Callum
2009-10-09 18:56:36 -07:00