- Bug was caused by absence of localizable string for "You paid..." notifications without name and reason simultaneously.
Added such string("you_paid_ldollars_no_info") to strings.xml and used it in code.
Reviewed by Vadim Savchuk at https://codereview.productengine.com/secondlife/r/206/
--HG--
branch : product-engine
- Limited height of gestures popup to 17 lines - 15 for gestures, 1 for label and 1 for separator. Used xml attribute "page_lines" to do it.
Reviewed by Mike Antipov at https://codereview.productengine.com/secondlife/r/199/
--HG--
branch : product-engine
Fixed code calculating title buttons rectangle, LLRect::isValid() does not indicate uninitialized rectangle, as a result rectangle was not properly initialized and had negative width.
Fixed title width.
Reviewed by Mike Antipov - https://codereview.productengine.com/secondlife/r/194/
--HG--
branch : product-engine
Implementation details:
* Added new LLViewerInventoryMoveFromWorldObserver to watch moved items via their Asses UUIDs. It is instantiated only once due to drop events are sent separately for each item while multi-dragging.
* Existent LLOpenTaskOffer observer uses it to exclude watched by LLViewerInventoryMoveFromWorldObserver items from own processing.
* Removed dependancy on LLPanelPlaces in open_inventory_offer(). Openning of offered LM via group notice moved into an appropriate section (processed by LLOpenTaskGroupOffer)
Known Issues:
* If Script item is among the dragged items from object to inventory it will be the only selected item in the inventory panel.
Reason: it does not have its own Asset UUID and processed via LLOpenTaskOffer when should not.
Reviewed by Leyla and Richard at https://codereview.productengine.com/secondlife/r/116/
--HG--
branch : product-engine
* reverted changes made previously by rev. f0663aa57134;
* added calculation of toast height difference based on LLTextBox::reshapeToFitText;
* added vertical centering of message textbox;
reviewed by Mike Antipov at
https://codereview.productengine.com/secondlife/r/195/
--HG--
branch : product-engine
- Added functionality of showing place profile to the LLPanelPlacesTab hierarchy. Use this functionality from LLPanelPlaces as callback for profile button click.
Reviewed my Mike Antipov at https://codereview.productengine.com/secondlife/r/191/
--HG--
branch : product-engine
Added "HttpOnly" to the allowed field names in LLPluginCookieStore::Cookie::parse(). (This was the actual cause of the failure -- cookies with this field in them were silently failing to parse.)
Added some LL_WARNS logging on this sort of cookie parse failure, which will make similar problems much easier to track down in future.
Also added tags to most of the logging in llplugincookiestore.cpp to make it easier to selectively enable it when debugging.
Added a cookie with all allowable field names to the unit test.
Reviewed by Sam at http://codereview.lindenlab.com/1247014
EXT-6692: crash at LLTextureCache::readEntryFromHeaderImmediately [secondlife-bin lltexturecache.cpp:1145]
EXT-6691: crash at LLTextureCache::writeEntryToHeaderImmediately [secondlife-bin lltexturecache.cpp:1126]
possible fix for EXT-6567: crash at LLImageBase::allocateData [secondlife-bin llimage.cpp:170]
Took out a bunch of code duplication from the FetchComboObserver and am using the LLFetchItems/DescendentsObservers instead. Also added some comments and made some minor superficial cleanup to LLInventoryObserver done().
-Set focus on sidetray tabs open to tab containers which hold panels with lists, so now filter fields are not emptied. Used "default_tab_group" + "tab_group" attributes in xml to implement this.
Reviewed by Vadim Savchuk at https://codereview.productengine.com/secondlife/r/198/
--HG--
branch : product-engine
* Removed unused InstantMessageLogFolder
* Restored initializing logic of InstantMessageLogPath value from 1.23 to share setting between viewers.
* Restored unused in 2.0 "LogChatTimestamp" and "LogChatIM" settings to avoid removing of them in 2.0
* Restored default value of the "Save local chat log" setting from 1.23 & replaced with 2.0 own setting (LogNearbyChat was: LogChat)
Reviewed by Igor Borovkov & Kent Quirk at https://codereview.productengine.com/secondlife/r/193/
(transplanted from 43297b92c1bb7487dab6610bea61acac4c355878)
* Added check of Avatar Picker floater (People Chooser) against NULL in search callback.
Reviewed by Vadim at https://codereview.productengine.com/secondlife/r/236/
(transplanted from 480f67e4eac0223626ce549a20760e81c4bce5b1)
Reason: not proper condition to check is LLSpeaker is in voice channel (implemented for EXT-3944)
Fix: Updated condition to check is speaker in voice channel state.
Reviewed by Vadim Savchuk at https://codereview.productengine.com/secondlife/r/242/
(transplanted from fb2af72d10231e04b2e79a7d487ea9e8559c14b8)
* Removed unused InstantMessageLogFolder
* Restored initializing logic of InstantMessageLogPath value from 1.23 to share setting between viewers.
* Restored unused in 2.0 "LogChatTimestamp" and "LogChatIM" settings to avoid removing of them in 2.0
* Restored default value of the "Save local chat log" setting from 1.23 & replaced with 2.0 own setting (LogNearbyChat was: LogChat)
Reviewed by Igor Borovkov & Kent Quirk at https://codereview.productengine.com/secondlife/r/193/
--HG--
branch : product-engine
Xiaohong Bao