- Added new pure virtual member function isSingleItemSelected() to the LLPanelPlacesTab. It is used in the LLPanelPlaces class inside onShowOnMapButtonClicked() to check if something was selected on the active panel. If so then selection is shown on the world map. Otherwise current agent position is shown on the world map.
- Implemented isSingleItemSelected() in the both LLPanelPlacesTab derived classes: LLLandmarksPanel and LLTeleportHistoryPanel
- Removed functionality which disables Map button if no selection is made
Reviewed by Sergey Litovchuk at https://codereview.productengine.com/secondlife/r/355/
--HG--
branch : product-engine
Implemented passing of entered filter substring without head spaces to search URI in help message for null filtered results.
* Updated setting "no item message" to use search term from filter editor for avatar & group lists and for inventory panels.
* Updated appropriate translatable strings to get [SEARCH_TERM] substitution.
* Updated processing of filter substring to pass original string to methods applied new filter.
Additional necessary changes
* Changed place to set "no item message" for group list from refresh to where filter is updated (like in avatar lists)
* Removed converting of filter substring to upper case in Places & My Appearance sidepanels (this conversion has already been implemented in where filter is applied)
* Added a separate message for Landmarks to set search URI to secondlife:///app/search/places for Lanmarks panel;
other inventory related panels have URL to all searched categories (secondlife:///app/search/all)
Reviewed by Vadim Savchuk at https://codereview.productengine.com/secondlife/r/326/
--HG--
branch : product-engine
Reason: LLFolderView::removeSelectedItems() was used to delete dropped items in Places Landmarks Panel. This led to calling this method N times where N is count of selected items. Due to removeSelectedItems() select one of non-removed items each time after removing of selected ones (2*N - 1) items were really deleted.
Fix: updated removing in Landmarks panel to remove dropped items one by one.
Reviewed by Richard at https://codereview.productengine.com/secondlife/r/204/
--HG--
branch : product-engine
- Added functionality of showing place profile to the LLPanelPlacesTab hierarchy. Use this functionality from LLPanelPlaces as callback for profile button click.
Reviewed my Mike Antipov at https://codereview.productengine.com/secondlife/r/191/
--HG--
branch : product-engine
- PLUS button works as GEAR button and PLUS button on inventory panel (show context menu on click)
- "Add a folder" menu item is always enabled (except for received folder)
- clicking "Add a folder" menu item creates a folder in My Landmarks tab no matter what has been selected in the Places panel before
Reviewed by Mike at https://codereview.productengine.com/secondlife/r/10/
--HG--
branch : product-engine
Landmarks panel after closing Create Landmark panel
- Added selecting landmark in landmarks panel after it was added or edited.
- Added expanding accordion tab containing the selected landmark.
--HG--
branch : product-engine
- Added check for folder view's folders being in expanded or collapsed state on "My Landmarks" tab.
- Added enabling/disabling of "Expand all folders" and "Collapse all folders" commands for landmark and folder "gear" menu.
--HG--
branch : product-engine
-- renamed files from llinventorysubtreepanel to llplacesinventorypanel
-- renamed class LLInventorySubTreePanel to LLPlacesInventoryPanel
--HG--
branch : product-engine
- Added drag and drop for empty inventory panel. Dropped item gets to
the root folder.
- Fixed issue with empty "Landmarks" inventory panel not displaying "No
matching items..." message.
- Removed accordion updating and hiding in idle routine. This invalidates EXT-2346 "My Landmarks accordion panels shouldn't be displayed if there are no landmarks in respective folders"
--HG--
branch : product-engine
EXT-1609 : Strange behavior for accordions in Places panel, Landmarks tab
Forcing top-level folders open when accordion is active. Removed logic that was saving and restoring initial folder state.
--HG--
branch : avatar-pipeline
Reason: Folder state of loaded folders was not saved before switching to Teleport history and back
Due to inventory loading was changed to fetch items in background it is impossible to save folder state while initializing of an Inventory panel.
Inventory observer was implemented to save folder states for Inventory Panels in all accordions.
Reviwed by Seth ProductEngine
--HG--
branch : product-engine
Took out line to start background fetch at start of filter; the background fetch will start when the filter is started. This prevents the viewer from requesting a complete inventory fetch at login.
--HG--
branch : avatar-pipeline
- Added enabling "Save" landmark button only after landmark is loaded.
Minor cleanup of fix for EXT-2346 "My Landmarks accordion panels shouldn't
be displayed if there are no landmarks in respective folders".
--HG--
branch : product-engine
I made it about a year and a half ago; Zero found it while reading code. I had added a return value to LLSD::insert(), but a) did it wrong, and b) broke the STL-like semantics of insert(). So I've put insert() back to returning void and created LLSD::with(), which does what my earlier insert() did. The compiler then caught all the cases where insert()'s return value were being used, and I changed those to use with() instead.
Vladimir Pchelko