Reason: in both cases the same - moderated mode is not checked when session participant list is filled with participants already in channel
(when IM or VCP is created)
Fix:
added updating of participants' speaker indicator mute state when list is refreshed.
Reviewed by Aimee Walton at https://codereview.productengine.com/secondlife/r/476/
--HG--
branch : product-engine
This is a workaround until a way to request the current voice channel moderation mode is implemented in the viewer.
Details:
* Added method to initialize Speaker manager's Voice moderate_mode once Agent's participant state is known.
* Once agent's voice participant is updated this method is called.
* This method initializes Voice moderate_mode only once.
This is necessary to process "Mute everyone" menu item calls properly.
Also renamed moderateVoiceOtherParticipants methods with moderateVoiceAllParticipants and related staff.
Reviewed by Aimee Walton at https://codereview.productengine.com/secondlife/r/448/
--HG--
branch : product-engine
* Replaced "Un/Mute everyone else" menu items with requested ones. They are enabled only on participants in Voice session (are shown for moderators)
* Actions implemented via existent "Un/Mute everyone else" functionality where "else" is NULL item.
Known issues:
* It is impossible to perform the same "Un/Mute everyone" action is session is already in requested state: EXT-6937
* If voice is disabled in a group session not all muted participants have appropriate indicator in VCP if resident joins to the session.
Due to this is the same behavior as before current patch is provided, a separate EXT-7235 bug is filed for this.
--HG--
branch : product-engine
Current patch fixes displaing of Avaline callers in Block List:
* Now it shows as Avaline Caller 1, etc.
Implemented via using name from AvatarListItem to create LLMute object.
Reviewed by Aimee Walton at https://codereview.productengine.com/secondlife/r/340/
--HG--
branch : product-engine
Applyied Aimee's patch to enable blocking of avaline caller:
added an "External" mute type which isn't sent to the SL servers or stored in the cache across sessions.
The caller's ID will change each time so there's no point cluttering up the mute list by persisting them.
Known issue: Right now the mute is added with the caller's phone number as the name shown in the block list,
so that will need changing to "Avaline Caller 1" etc
--HG--
branch : product-engine
Added 'VoiceFontDefault' saved setting.
Implemented LLVoiceClientFontsObserver to update the UI when the voice font list is received.
Renamed LLVoiceClientParticipantObserver::onChange() to onParticipantsChanged to avoid ambiguity and make the code more readable.
Made the Voice Font combo in the VCP auto resize to make best use of the available space when the 'Leave Call button is not visible.
* Disabled all currently processed menu items related to interaction with a resident for Avaline callers.
* Added enable callback for View Profile menu item to disable it for Avaline callers.
* Disabled menu items related to text chat.
Full list is:
- View Profile
- Add Friend
- IM
- Call
- Share
- Pay
- Block Text
- Moderate Options:
-- Allow Text chat
DEV notes: To process moderation options separate "on_enable handler" was created for group moderate actions.
Reviewed by Vadim Savchuk at https://codereview.productengine.com/secondlife/r/261/
--HG--
branch : product-engine
* Implementation notes:
** special item is cloned from VCP to be used in LLAvatarList to reflect an Avaline caller.
** LLAvatarList extended to create instances of Avaline Caller
** Participant list now determines type of adding session participant (Avatar/Avaline Caller) and selects a way item will be created in avatar list
* Implementation behavior:
** The problem is when Avaline caller ends a call it is removed from Voice Client session but
still exists in LLSpeakerMgr. Server does not send such information.
HUCK was implemented to notify subscribers that Avaline callers are not anymore in the voice call.
** For now Avaline Caller is removed from the LLSpeakerMgr List when it is removed from the Voice Client session.
This happens in two cases: if Avaline Caller ends call itself or if Resident ends group call.
** If Resident joins group call where Avaline caller already exists that caller will appear in Resident's viewer (VCP & Group IM window)
** The callers are displayed as "AvaLine Caller 1", "AvaLine Caller 2" etc.
* Known issues:
** LLNonAvatarCaller should be removed from VCP (for avaline p2p calls). Updated Avatar & Participant Lists can be used instead of it.
Separate ticket will be opened to refactor this code.
--HG--
branch : product-engine
- Enabling/disabling 'Call'menu item is moved to createMenu(). Some way to properly enable/disable it in
enableContextMenuItem() should be found.
--HG--
branch : product-engine
- Added check for call availability in miniinspector's context menu
- Removed ability to call yourself in group chat context menu
- Added check for call availability for context menu which appears on right mouse click on avatar in game area
--HG--
branch : product-engine
(Should not be able to start a call when voice is disabled). Call buttons state now reacts on
voice changes in time.
- Added voiceWorking() method to LLVoiceClient to determine real availability of voice, because voiceEnabled()
doesn't take into account possible errors. Perhaps there is no need in two methods- some investigation will be
made and depending on its results they may become one non-static method. voiceWorking() uses state of voice
client(mState) to determine voice availability. Also some states which are not currently counted by voiceWorking()
as valid may be added if testing reveals problems.
- To enable/disable call buttons in time, LLVoiceClientStatusObserver is used. Its trigger uses states from its
enum only to skip updating button in some states(to avoid button blinking), but to determine button state
LLVoiceClient's voiceWorking() is used.
--HG--
branch : product-engine
Code improved:
* removed disabled method LLAvatarListItem::reshapeAvatarName
* added refreshing chat participant list immediately after moderator rights are changed (for EXT-2364)
--HG--
branch : product-engine
- improved condition to check if avatar can be moderated.
- if not moderation panel (with "Disable Voice" button) is not shown at all.
--HG--
branch : product-engine
-- fixed incorrect condition while checking if added avatar is a valid speaker (improvements for original fix - 62a452bcea55)
--HG--
branch : product-engine
Mike Antipov