Commit Graph

51 Commits (9edad026f4494de1a6f02ecc3f477faa27a361ef)

Author SHA1 Message Date
Kitty Barnett e5990f9880 Once more for good measure 2016-12-03 20:31:13 +01:00
Kitty Barnett 4503a28aee Merged with RLVa fixes 2016-12-03 17:13:17 +01:00
Kitty Barnett 0581c4749d Merged with Appearance-Misc tip
--HG--
branch : RLVa
2016-12-03 13:07:14 +01:00
Kitty Barnett 9cacb279b9 Merged with Appearance-SyncAttach fixes/review
--HG--
branch : Appearance-Misc
2016-11-26 21:58:39 +01:00
Kitty Barnett 07ad25c6be Added "Refresh Attachments" to reattach remote-detached but local-phantom attachments
-> plays nice with RLVa

--HG--
branch : Appearance-Misc
2016-11-26 21:56:45 +01:00
Kitty Barnett 351c4f7709 Refactoring carousel: prefer RlvActions over RlvHandler wherever possible
-> clean up some quick wins; no functionality changes

--HG--
branch : RLVa
2016-11-20 11:57:08 +01:00
Kitty Barnett 4e99177b14 Merged with Appearance-Misc tip
--HG--
branch : RLVa
2016-11-14 20:15:31 +01:00
Kitty Barnett bac1de6c68 Reviewed Appearance-SyncAttach for Catznip-R11
-> none of the work on AIS fixes the original problem from 6 years ago (see VWR-18512 and previous changesets in Appearance-Misc patch branch)
  -> Repro:
       * folder with 1 attachment and 2 wearables
       * double-click (in rapid succession) wearable 1, then attachment A and finally wearable 2
       => after double-clicking wearable 2 the attachment will end up detached

--HG--
branch : Appearance-Misc
2016-11-14 20:12:11 +01:00
Ansariel e10409d95e FIRE-20365: Viewer crashes during shutdown due to dangling LLRequestServerAppearanceUpdateOnDestroy instance caused by temp attachments being attempted to link in COF 2016-11-18 13:30:42 +01:00
Kitty Barnett c3c7e97eed Merged with default tip (Revision 353c4cb529e2)
--HG--
branch : Appearance-Misc
2016-10-02 19:55:19 +02:00
Kitty Barnett 0046a76489 Merged with default tip (Revision 353c4cb529e2)
--HG--
branch : RLVa
2016-10-03 22:39:14 +02:00
Ansariel 3192fe832f Merge viewer-quickgraphics 2016-03-08 01:41:31 +01:00
Oz Linden 5822fb00b6 merge DRTVWR-398 build cleanup fixes 2016-03-07 12:41:11 -05:00
Oz Linden c8726aba30 remove execute permission from many files that should not have it 2015-11-10 09:48:56 -05:00
Ansariel 5524d38dff Merge viewer-quickgraphics 2015-10-03 16:38:26 +02:00
andreykproductengine 47dfdff3c0 MAINT-5570 limiting exposure of attachment manager 2015-09-21 20:36:21 +03:00
Kitty Barnett 7fa9ac3ddb Merged with Appearance-Misc tip for big bird
--HG--
branch : RLVa
2015-06-25 19:26:11 +02:00
Kitty Barnett 0178fcde27 - fixed : wearing something while an inventory link is pending will detach the attachment and potentially leave an unworn COF link
-> we already fixed this in 2010 so we just apply the fix that works on top of the fix that doesn't; some day they'll get it right
    -> Repro on big bird (there are many more ways to trigger the bug but this is the easiest):
        * rez an object from inventory
        * double-click a wearable from inventory (before the link creation call kicks in)
        => the wearable kicks off an LLUpdateAppearanceOnDestroy which detaches the unlinked attachment (the link will arrive eventually and be unworn)
        => note that leaving a link in COF to an attachment that isn't worn anymore is a bug in its own right (though I guess that's why "questionable links" were added)

--HG--
branch : Appearance-Misc
2015-06-25 09:27:06 +02:00
Kitty Barnett 332b4a40e1 - fixed : questionable code is questionable (aka LLAttachmentsMgr::checkInvalidCOFLinks seems redundant)
-> the way to trigger the function seems to be (with the proper timing sequence):
        * Script an attachment to detach on attach
        * Wear the attachment => link creation request is sent
        * Detach the attachment => link is still pending so can't be removed
        * Link is created => at some point in time the function notices an unworn COF link and removes it
    -> Appearance-SyncAttach will verify the attachment is still worn when the link is created so if the above is the use case for this function then we're already handling it
    -> failing the catch by onRegisterAttachmentComplete the attachment will be re-attached by updateAppearanceFromCOF (which will happen with the LL function if an item is worn before the time-out kicks in)

--HG--
branch : Appearance-Misc
2015-06-25 03:53:47 +02:00
Kitty Barnett d2665cabbf - fixed : attaching a rezzed object delays attachment link creation by 5 seconds
-> LLSelectNode::mItemID is NULL for a newly created in-world object or the old inventory item UUID if it was rezzed from inventory
    -> a new inventory UUID will be assigned so there's no use in waiting for an item that will never come (and we should never wait on the NULL UUID)

--HG--
branch : Appearance-Misc
2015-06-25 02:15:18 +02:00
Kitty Barnett d933e6ea73 - fixed : don't start creating links to attachments until LLAppearanceMgr::setAttachmentInvLinkEnable has been called
--HG--
branch : Appearance-Misc
2015-06-25 02:00:10 +02:00
Brad Payne (Vir Linden) e2544fabe5 MAINT-5222 WIP - checks for app shutting down a couple of places. 2015-05-18 13:10:26 -04:00
Brad Payne (Vir Linden) ff42e55784 DRTVWR-397 WIP - comments and logging 2015-04-24 10:06:30 -04:00
Brad Payne (Vir Linden) 4d689fc515 MAINT-4653 WIP, DRTVWR-397 WIP - log output to file now includes tags. Request max 5 attachments per idle loop to reduce sim-side failures seen when requesting large numbers. 2015-04-22 16:09:02 -04:00
Brad Payne (Vir Linden) 0e0339914f MAINT-5070 WIP, MAINT-4409 WIP - try to clean up invalid COF links under certain circumstances. 2015-04-10 16:13:51 -04:00
Brad Payne (Vir Linden) 6ac9852d54 MAINT-5069 WIP, MAINT-5071 WIP - handle dropping objects and attaching from ground. WIP on better tracking of attachment requests via various message in LLSelectMgr. 2015-04-09 13:29:39 -04:00
Brad Payne (Vir Linden) f1684cdea5 DRTVWR-397 WIP - more logging 2015-04-02 17:47:22 -04:00
Brad Payne (Vir Linden) b40bdb266a DRTVWR-397 WIP - logging updates and fixes 2015-03-31 14:18:49 -04:00
Brad Payne (Vir Linden) 81f9c81fe7 DRTVWR-397 WIP - ATT logging 2015-03-20 11:27:47 -04:00
Brad Payne (Vir Linden) 6fc663d62a DRTVWR-397 WIP - logging for detach requests and unexpected detaches (presumably server-initiated) 2015-03-20 11:03:47 -04:00
Brad Payne (Vir Linden) 779d5ac56e MAINT-4917 WIP - debug line added. 2015-03-19 17:38:57 -04:00
Brad Payne (Vir Linden) 8963185f5b MAINT-4917 WIP - comments and bug fixes for batching up COF link requests after attachments added. 2015-03-19 17:05:55 -04:00
Brad Payne (Vir Linden) 090d3097d5 MAINT-4917 WIP - Attachment deferred bulk COF linking WIP 2015-03-18 21:41:47 -04:00
Brad Payne (Vir Linden) 8169cde890 MAINT-4653 WIP 2015-03-03 17:08:34 -05:00
Brad Payne (Vir Linden) 43aac9ad1d MAINT-4918 WIP - batch up detach requests for objects 2015-02-27 10:28:50 -05:00
Brad Payne (Vir Linden) 58ab202aa2 MAINT-4917 WIP - batch COF link request before batch attachment request. Should only generate one bake request. 2015-02-24 16:19:14 -05:00
Brad Payne (Vir Linden) 7b99314d84 MAINT-4653, DRTVWR-397 WIP - more code for tracking attachment operations, smarter handling of multiple requests. 2015-02-20 15:54:27 -05:00
Brad Payne (Vir Linden) 1f2404aa29 Logging for attachments and their COF links 2015-02-18 16:44:36 -05:00
Tonya Souther b2e0ebee8b Compile fixes for compilers that aren't Visual C++, from Kitty Barnett. 2015-07-18 20:27:47 -05:00
Kitty Barnett d305028f70 - internal : random apperance-related reviewing
--HG--
branch : RLVa
2014-10-30 01:18:42 +02:00
Kitty Barnett c4d557d529 Merged with default tip (Revision aeab2661776f)
--HG--
branch : RLVa
2014-10-29 21:45:12 +02:00
Richard Linden e340009fc5 second phase summer cleaning
replace llinfos, lldebugs, etc with new LL_INFOS(), LL_DEBUGS(), etc.
2013-08-09 17:11:19 -07:00
Kitty Barnett 10a289598b Merged with default tip (Revision 74cc289067c8)
--HG--
branch : RLVa
2013-07-21 22:33:04 +02:00
Graham Madarasz bf6182daa8 Update Mac and Windows breakpad builds to latest 2013-03-29 07:50:08 -07:00
Kitty Barnett e1b955226d Merged with viewer-sunshine tip (Revision bd1162cb6fbe)
--HG--
branch : RLVa
2013-02-11 23:04:05 +01:00
Nicky 60393abdad Crashfix: In LLAttachmentsMgr::onIdle make sure we've a valid region before dereferencing it. 2012-07-13 13:37:18 +02:00
Kitty Barnett c80812fb9f - internal : header dependency cleanup for rlvcommon.h and rlvhandler.h
--HG--
branch : RLVa
2011-05-22 11:34:34 +02:00
Kitty Barnett c7f1a21f9c - internal : moved "can attach" checking code from LLAttachmentsMgr::onIdle() to LLAttachmentsMgr::addAttachment()
-> since "onIdle" runs in the next (idle) frame the restrictions may differ from what they were when "addAttachment" was called

--HG--
branch : RLVa
2010-09-23 22:26:38 +02:00
Kitty Barnett 24955c2d39 - internal : SVC-5383 appears to be fixed so we'll use RezMultipleAttachmentsFromInv for force-wearing once more
--HG--
branch : RLVa
2010-09-15 23:39:56 +02:00
Kitty Barnett b04ea28222 - internal : moved code from confirm_attachment_rez() to LLAttachmentsMgr class
- internal : RlvAttachmentLockWatchdog::attach() uses RezSingleAttachmentFromInv directly
    -> check whether http://jira.secondlife.com/browse/SVC-5383 is still an issue

--HG--
branch : RLVa
2010-09-15 23:27:14 +02:00