-> Description:
- changed : LLCacheName::buildUsername() will properly extract the username if the passed name is a "complete name"
-> "Catznip Catnap" => "catznip.catnap"
-> "Catznip Tester (catznip.catnap)" => "catznip.catnap"
- fixed : P2P IM session names are inconsistent (chiclet hover tip shows the legacy name rather than the complete name for incoming IM sessions)
-> incoming IM session would have a session name of "Catznip Catnap" (legacy name)
-> outgoing IM session would have a session name of "Catznip Tester (catznip.catnap)" (complete name)
-> standarized P2P IM session names to "complete name"
- added : LLIMModel::buildIMP2PLogFilename() to have one single function to construct log filenames for P2P IMs
- fixed : teleport offers to another avie are logged to the wrong file when no IM session is open for that avie
-> open IM session => logged to "catznip_catnap.txt"
-> no open IM session => logged to "Catznip Catnap.txt"
- fixed : inventory offers to another avie are logged to the wrong file when no IM session is open for that avie
-> no open IM session => logged to "Catznip Catnap.txt"
- fixed : inventory accepted/declined notifications are logged to the wrong file
-> no open IM session => logged to secondlife____app_agent_<uuid>_completename.txt
- added : "UseLegacyIMLogNames" setting to use "old-style" log filenames for P2P IM sessions (TRUE by default)
-> needed for people who mix older and newer viewers
-> side-steps any other remaining bugs due to log filename change
- Repaired ability to disable chat toasts
- iniitial implementation to disable chat icons
- initial groundwork for separate color for chat header names
Modified code in indicated changeset to correct problem after consulting with
Leyla Linden who sugested the orginal change. This fix will convert the Legacy
name to a user name id not useing Display Names.
and also changed the name used for P2P IM log file names. The latter change is going to
temporarely break personal content for those that are saving conversation logs as P2P IM
logs will now be useinf the user name and not the legacy name.
HUDtext updates may be broken, much testing needed.
I expect this merge to be improved and even fully replaced by up and coming RLVa work.
When we do get a clean merge of RLVa, it should stay clean.
It does compile ;)
This regression was caused by fix of STORM-126 in changeset 09f13edf6aa8 where adding of people from mInitialTargetIDs was removed.
And it was used to add people whom you P2P im'ed.
- Used mInitialTargetIDs to add people whom you P2P im'ed.
Both offline and online users are added. It is done in LLVoiceChannelGroup::activate(), where TODO for it was placed earlier.
To avoid code duplication when adding users from speakers list to Recent, a new method was added to LLIMModel.
Bug was caused by using unlocalized name of session as argument in LLIMModel::newSession() after the session name was localized in constructor.
- Used correct session name in LLIMModel::newSession(). Adding similar logic to addMessage() turned out to be unnecessary and also caused regression (VWR-23180),
so previous fix of the same bug(8ab901af1241) was backed out in 28ed1b4cf4cd. Erroneous part was excluded from this fix.
- Moved the "no session" string to XML and used it in code instead of hardcode.
- Conference string turned out to be already translated, but the way translation was happening ad-hoc chat log files on disk
would get localized names, and thus be inconsistent (and that would create problems with browsing them later).
It didn't happen already just because this string wasn't translated in other locales somewhy.
So moved localization of session name after the the creation of log file.
Also changed value of string according to Eli's comment in ticket.
Bug was caused by using incorrect (unlocalized) name of session as argument for some methods after the session name was localized in constructor.
- Used correct (localized) session name instead.
Used previously commented code which adds only online paricipants instead of current code that added all.
Reviewed by Vadim Savchuk at https://codereview.productengine.com/secondlife/r/860/
--HG--
branch : product-engine
Tank_Master