There were two problems:
1. Underlining broke when avatar's first and second name were on different lines.
2. There was no underline on hover for avatar miniinspector links in plaintext IM.
- First problem was caused by calling LLOnHoverChangeableTextSegment::draw() for the same segment twice- for first and second name that were
on different lines, while handleHover() was called only once. So handleHover() was called -> text was underlined -> first part of segment was
drawn underlined -> its draw set style back to normal -> second part of segment was drawn without underlining.
Fixed this by setting style back to normal only when drawing the last part of the segment.
- Second problem was caused by unusual way of appending link to text in chat history.
Changed it so that LLTextBase::appendText() now receives link not inside style params, but directly.
Also added "/inspect" ending to check in LLUrlEntryAgent::underlineOnHoverOnly().
Reviewed by Richard Nelson at https://codereview.productengine.com/secondlife/r/833/
--HG--
branch : product-engine
Reason
======
Each message in an IM/chat session has a header. The header shows an (i) button on hover and hides it when mouse leaves the header.
The button is shown by adding it as a header child and hidden by resetting the button parent.
So, if you close the IM session so that the hovered header doesn't get the MouseLeave message (e.g. by Ctrl+W),
the button gets destroyed. If you then open the IM session again and hover a message header, the destroyed button
is referenced, which leads to crash.
Fix
===
We make sure that when a hovered message header is being destroyed (by closing the IM session),
the button is detached (i.e. its parent gets reset), so that it remains usable.
I also add a couple of checks for the case when the (i) button fails to construct from XML file.
Reviewed by Mike Antipov at https://codereview.productengine.com/secondlife/r/783/
--HG--
branch : product-engine
Messages coming from objects named "Second Life" were mistaken for messages coming from system
under the name "Second Life".
It is impossible to distinguish using the from_id and from_name two cases:
- messages coming from system under the name "Second Life" but under the id of an object
- messages comding from object named "Second Life"
Reviewed by Mike Antipov at https://codereview.productengine.com/secondlife/r/556/
--HG--
branch : product-engine
Includes: DEV-45800, DEV-45803 - Grid Manager
DEV-45804 - SLURL refactor
DEV-45801 - Single username field (for Identity Evolution and SLE Ldap)
Also,
Includes Certificate Management code allowing the viewer to connect to
grids not signed by a well know key (just like any web browser). Also
contains secure storage for things like passwords.
The security/certificate code is modular with the intention of adding modules
to directly use the operating system facilities for crypto if available.
(that's much more secure than we'll ever be)
Also, refactor of voice to modularize it, and add a diamondware voice module.
CR: Aimee, James, Lynx, Mani, Karina and a list of thousands
To fix EXT-6373 I added vertical padding between posts in plain-text and
unified padding in default mode of IM/chat history.
Now I'm backing out the changes to plain-text mode that led to EXT-3818.
reviewed by Leyla Farazha at
https://codereview.productengine.com/secondlife/r/95/
--HG--
branch : product-engine
plain text chat was enabled while unresolved offer was in hided IM window”,
Added check to LLToastNotifyPanel destructor whether we should close
notification since notification will be reused by IM floater when reload
messages, the rule is: if LLToastNotifyPanel destroying but IM floater is
exists – we shouldn't close notification.
The problem is that notification was incorrectly deleted when IM floater
reloads messages on chat log fromat change event.
reviewed by Vadim Savchuk at
https://codereview.productengine.com/secondlife/r/80/
--HG--
branch : product-engine
- Button order was fixed in changeset dd44dac25177. It was an implemetation of EXT-5906 (Reverse buttons order in the inventory offers). That changeset
was included in cumulative diff at https://codereview.productengine.com/secondlife/r/52/ and already made its way into viewer 2-0.
- This changeset removes inventory offer button truncation in IM in German locale by increasing default width of IM floater and decreasing distance between buttons.
Reviewed by Vadim at https://codereview.productengine.com/secondlife/r/77/
--HG--
branch : product-engine
- new chat source type CHAT_SOURCE_UNKNOWN for avatar names not in cache and object names consisting of two words (avatar names like)
- new icon (unknown_icon.png) for message headers () of nearby chat messagses coming from CHAT_SOURCE_UNKNOWN
- context menu no longer displayed for object names from chat history (no UUIDs)
- double click on message headers in nearby chat no longer opens Inspector (no UUIDs)
- object names (loaded from chat history) in nearby chat are no longer SLURLed (no UUIDs for them)
--HG--
branch : product-engine
Completed things which were agreed on:
- system messages in the log file are prepended with "Second Life:" after the timestamp
- object names set which are parsed extended to object names consisting with any number of words
Side effect:
"Second Life:" is shown as From Name in Nearby Chat when in plain text chat
--HG--
branch : product-engine
Richard Nelson