* Added checkbox that will show if region windlight settings are used and can also enable/disable usage of them
* Added combobox for day cycle presets
* The sky preset combobox will show "Day cycle based", if the current sky preset is defined by the selected day cycle and time of day
* The sky preset combobox will show "Region default", if the current sky preset is based on region windlight
* The water preset combobox will show "Region default", if the current water preset is based on region windlight
* The day cycle combobox will show "Region default", if the current day cycle preset is based on region windlight
* The day cycle combobox will show "None", if no day cycle preset is active (if a sky preset is chosen)
* Changing either sky, water or day cycle preset will disable region windlight and persist as user setting
* The slider will either change day of time (day cycle active) or sun position (sky preset chosen)
* Reset to region defaults button will reset sky and water to region defaults, but not enable region windlight and not persist
(not doing so would disallow us from changing either sky or water)
* Disabling region windlight will load previously chosen sky, water and day cycle preset (this is intentional because of the implementation of the basic Windlight functionality)
Changes:
* Subscribed the floater to the "settings changed" signal of the environment manager.
* Rewrote the floater to not modify settings only when the Save button is pressed.
* Refactoring to eliminate code duplication.
Was: Press "Save" after editing the region day cycle in the Day Cycle Editor.
Now:
- Press "Save" in the Day Cycle Editor.
- Open Region / Estate -> Environment tab.
- Select the region day cycle.
- Press "Apply".
Done:
* Creating new local day cycles.
* Editing existing local day cycles.
* Deleting day cycles.
To do:
* Editing region day cycle, dealing with skies in region scope.
* Handle teleport while editing a day cycle.
* Update UI when a day cycle or sky preset gets deleted.
* Make the time ctrl increase/decrease consistently.
Reason: We tried to check whether the region supports environment settings
without making sure that we've actually recieved region capabilities,
so the check sometimes failed.
Fix: Defer check for the "EnvironmentSettings" capability until we've received the region capabilities.
* Made it possible to update a region sky preset with the Save button.
* Fixed resetting day cycle when you start editing region environment settings.
* Fixed: if you press "Cancel Changes" in the region envitonment settings
and then choose to resume editing in the confirmation dialog,
you won't be able to cancel your changes later.
* Added "Apply Local to Region" button to the region terrain setttings panel.
* Fixed previewing presets via a combomox in the Advanced Sky Editor floater.
Changes:
* Fixed incorrect way to pass parameters to notifications.
* Fixed crashes in the Advanced Sky floater and the Region Terrain panel.
* Fixed initialization and multiple instantiation of the Day Cycle floater
(that might lead to incorrect behavior).
* Fixed and re-enabled committing env. settings changes to region.
* Fixed day cycle and sky settings being sent as empty arrays and therefore not passing validation on server.
It is now possible to change region environment settings.
* Added debug messages.
Lots of cleanup in the floater classes. Not sure every decision was correct
but it compiles now. Doesn't link yet.
(resubmitted by Vadim ProductEngine)
Ansariel