The problem was caused by trying to lookup info for a *remote* object by its id in the gObjectList --
this is what the usual object inspector (LLInspectObject) does.
The fix saves the sender object info when a message arrives, then passes the info to the remote object inspector (LLInspectRemoteObject).
Changes:
* Suppressed URLs in object (sender) names of nearby chat messages loaded from history.
* Fixed text between <nolink>...</nolink> text being rendered as URL
(hand cursor on hover, context menu, context menu, opening Places SP on click).
The reason is the same as in STORM-390: a bug in LLTextBase which leads to ignoring link href specified for a link segment if
the segment contains an URL (and the <nolink>...</nolink> clause is treated as such).
The workaround is to explicitly disallow parsing URLs in a link segment by setting its "is_link" parameter to "true".
- Added argument show_images to constructors of LLIMToastNotifyPanel and LLToastNotifyPanel. Depending on it plaintext attribute for textbox with notification text is set. Used this argument when adding notification to chat history if IM is in plaintext mode.
There were two problems:
1. Underlining broke when avatar's first and second name were on different lines.
2. There was no underline on hover for avatar miniinspector links in plaintext IM.
- First problem was caused by calling LLOnHoverChangeableTextSegment::draw() for the same segment twice- for first and second name that were
on different lines, while handleHover() was called only once. So handleHover() was called -> text was underlined -> first part of segment was
drawn underlined -> its draw set style back to normal -> second part of segment was drawn without underlining.
Fixed this by setting style back to normal only when drawing the last part of the segment.
- Second problem was caused by unusual way of appending link to text in chat history.
Changed it so that LLTextBase::appendText() now receives link not inside style params, but directly.
Also added "/inspect" ending to check in LLUrlEntryAgent::underlineOnHoverOnly().
Reviewed by Richard Nelson at https://codereview.productengine.com/secondlife/r/833/
--HG--
branch : product-engine
Reason
======
Each message in an IM/chat session has a header. The header shows an (i) button on hover and hides it when mouse leaves the header.
The button is shown by adding it as a header child and hidden by resetting the button parent.
So, if you close the IM session so that the hovered header doesn't get the MouseLeave message (e.g. by Ctrl+W),
the button gets destroyed. If you then open the IM session again and hover a message header, the destroyed button
is referenced, which leads to crash.
Fix
===
We make sure that when a hovered message header is being destroyed (by closing the IM session),
the button is detached (i.e. its parent gets reset), so that it remains usable.
I also add a couple of checks for the case when the (i) button fails to construct from XML file.
Reviewed by Mike Antipov at https://codereview.productengine.com/secondlife/r/783/
--HG--
branch : product-engine
Messages coming from objects named "Second Life" were mistaken for messages coming from system
under the name "Second Life".
It is impossible to distinguish using the from_id and from_name two cases:
- messages coming from system under the name "Second Life" but under the id of an object
- messages comding from object named "Second Life"
Reviewed by Mike Antipov at https://codereview.productengine.com/secondlife/r/556/
--HG--
branch : product-engine
Start with blank header to hide sample text from XUI XML. Also fixed
problem with computation of minimum chat header name width when the
name wasn't in cache.
Vadim ProductEngine