The bug was introduced in the fix of EXT-4700 (Creating a landmark brings up the Landmark sidepanel info twice).
To avoid reopening the "Create Landmark" panel, its Back and Close buttons were disabled.
However, the same fix removed the code for reopening the panel, so I can't see why we need to disable the buttons at all.
Changes:
* Changed the button class from LLButton to LLMenuButton to avoid duplicating menu positioning logic.
* Enabled LLMenuButton to support aligning menu to the top right corner of the button.
- Added new pure virtual member function isSingleItemSelected() to the LLPanelPlacesTab. It is used in the LLPanelPlaces class inside onShowOnMapButtonClicked() to check if something was selected on the active panel. If so then selection is shown on the world map. Otherwise current agent position is shown on the world map.
- Implemented isSingleItemSelected() in the both LLPanelPlacesTab derived classes: LLLandmarksPanel and LLTeleportHistoryPanel
- Removed functionality which disables Map button if no selection is made
Reviewed by Sergey Litovchuk at https://codereview.productengine.com/secondlife/r/355/
--HG--
branch : product-engine
Implemented passing of entered filter substring without head spaces to search URI in help message for null filtered results.
* Updated setting "no item message" to use search term from filter editor for avatar & group lists and for inventory panels.
* Updated appropriate translatable strings to get [SEARCH_TERM] substitution.
* Updated processing of filter substring to pass original string to methods applied new filter.
Additional necessary changes
* Changed place to set "no item message" for group list from refresh to where filter is updated (like in avatar lists)
* Removed converting of filter substring to upper case in Places & My Appearance sidepanels (this conversion has already been implemented in where filter is applied)
* Added a separate message for Landmarks to set search URI to secondlife:///app/search/places for Lanmarks panel;
other inventory related panels have URL to all searched categories (secondlife:///app/search/all)
Reviewed by Vadim Savchuk at https://codereview.productengine.com/secondlife/r/326/
--HG--
branch : product-engine
Problem:
"Profile" button is visible when viewing current agent place info and remote parcel info.
Solution:
Hide "Profile" button when we are viewing place profile. Updated "Profile" button visibility condition. New condition hides the button when viewing landmark info, teleport history info, agent place info and remote parcel info.
Bug introduced in changeset 11252 : c5b3adc89f28 (EXT-6605 (No profile verb button on Places panel))
Reviewed by Mike Antipov - https://codereview.productengine.com/secondlife/r/274/
--HG--
branch : product-engine
- Added functionality of showing place profile to the LLPanelPlacesTab hierarchy. Use this functionality from LLPanelPlaces as callback for profile button click.
Reviewed my Mike Antipov at https://codereview.productengine.com/secondlife/r/191/
--HG--
branch : product-engine
sidepanel info twice.
- Disabled "Close" and "Back" buttons to prevent closing "Create Landmark" panel until created landmark is loaded.
--HG--
branch : product-engine
Landmarks panel after closing Create Landmark panel
- Added selecting landmark in landmarks panel after it was added or edited.
- Added expanding accordion tab containing the selected landmark.
--HG--
branch : product-engine
We now disable the teleport/map buttons when they cannot be used (when
we don't have a global 3D position for the parcel). We also update
this button enable state at the right times.
When we open the Places side tray for a parcel, given a UUID, we now
look up the parcel's global 3D position so that the teleport and map
functions work correctly.
- Added enabling "Save" landmark button only after landmark is loaded.
Minor cleanup of fix for EXT-2346 "My Landmarks accordion panels shouldn't
be displayed if there are no landmarks in respective folders".
--HG--
branch : product-engine
Vadim ProductEngine