There were two nearly-identical copies of a stanza that calls sendURLToOtherInstance(). Remove one. It's possible that the reason no one noticed the duplication was because the two copies were 70 lines apart. Move setSkinFolder(), setUseSpellCheck() and setSecondaryDictionaries() stanzas to consolidate SLURL-handling code more closely. Also move logic for NextLoginLocation and CmdLineLoginLocation. Remove a couple unnecessary std::ostringstream instances. Streaming a single string literal to std::ostringstream and retrieving its str() is the same as simply converting the literal to std::string, only slower. OSMessageBox() accepts const std::string&. Given that you have a std::string in hand, passing its c_str() to OSMessageBox() is not only unnecessary but wasteful: it requires silently converting the const char* back to a different std::string instance. Calling a class method from another method of the same class does not require ClassName:: qualification. Calling a singleton subclass method from another non-static method of the same subclass does not require going through ClassName::instance() or sInstance or whatever. |
||
|---|---|---|
| debian | ||
| doc | ||
| etc | ||
| indra | ||
| scripts | ||
| .hgignore | ||
| .hgtags | ||
| BuildParams | ||
| README.md | ||
| autobuild.xml | ||
| build.sh | ||
README.md
Second Life Viewer
This project manages the source code for the Second Life Viewer.
This source is available as open source; for details on licensing, see the licensing page on the Second Life wiki
For information on how to use and contribute to this, see the open source portal on the wiki.
To download the current default version, visit the download page. For even newer versions try the Alternate Viewers page