Commit Graph

213 Commits (1bbad3fd00a9db28944bab1ec9c0e10fd5d1c2f2)

Author SHA1 Message Date
Maxim Nikolenko 1924241f04
viewer-private#375 add more logging in attempt to get more info 2025-02-07 19:00:20 +02:00
Andrey Kleshchev 0114be2c15 viewer#2985 Odd crash when notifying voice observers
Crash points at enableDisableCallBtn, but button's floater was cleaned
earlier and has a removeObserver call so an observer record should be
long gone. Likely something else is going on.
Went over various callbacks and made sure they are cleaned. But in case
floater somehow remained, added mSession = nullptr.
2024-11-01 17:54:05 +02:00
Roxie Linden 3017b1bae1 Don't enable vivox spatial when teleporting while in a webrtc conference/p2p/group call
Processing for vivox was being enabled when teleporting into a vivox region
regardless as to whether the user was in a conference/p2p/group call, resulting
in vivox spatial and webrtc conference/p2p/group simultaneously being active.
2024-09-06 12:00:00 -07:00
Brad Linden 5f26ba8014 Merge remote-tracking branch 'origin/release/webrtc-voice' into release/2024.06-atlasaurus
# Conflicts:
 #	indra/newview/llpanelpeople.cpp
2024-08-15 09:41:54 -07:00
Andrey Kleshchev e086437f12 viewer-private#262 webrtc crashes on shutdown
removeObserver failed to remove an im session floater
2024-08-13 19:30:17 +03:00
Brad Linden 3b2c32fdf9 Merge remote-tracking branch 'origin/release/webrtc-voice' into release/2024.06-atlasaurus
# Conflicts:
 #	.github/workflows/build.yaml
 #	indra/newview/CMakeLists.txt
 #	indra/newview/llspeakers.cpp
 #	indra/newview/llvoicechannel.cpp
 #	indra/newview/llvoicechannel.h
 #	indra/newview/llvoiceclient.cpp
 #	indra/newview/llvoiceclient.h
 #	indra/newview/llvoicewebrtc.cpp
2024-08-09 15:10:13 -07:00
Roxie Linden 227b212dc6 Teleport to a region with a different voice server type causes failure in voice
When teleporting, the viewer 'hides' voice, effectively disabling it, until the teleport
has completed.  It does this by instructing the voice module to hide and then unhide.

The problem was, it would instruct one voice module for one voice server type to hide,
and then after teleport, it would instruct the other voice module for the other voice
server type to unhide, resulting in one voice module being hidden.

When the user transitions back to a region with the initial voice module, it's hidden,
hence voice doesn't work.

The solution is to hide/unhide both voice modules.
2024-08-09 12:04:19 -07:00
Andrey Kleshchev 9094d0281d Adjust some LLVoiceClient functions
Feels like I should have made isParticipant and getParticipantList
static to minimize singleton dependency/calls
2024-08-07 14:19:49 +03:00
Brad Linden 002be0f243 Merge remote-tracking branch 'origin/release/webrtc-voice' into release/2024.06-atlasaurus 2024-08-01 15:40:41 -07:00
Andrey Kleshchev f75735d741 viewer-private#255 p2p outgoing calls did not work correctly #2 2024-07-30 07:31:05 +03:00
Brad Linden ed73208eb9 Merge remote-tracking branch 'origin/release/webrtc-voice' into release/2024.06-atlasaurus 2024-07-24 16:55:49 -07:00
Brad Linden 26a01ced9a Improve error message notifying user that Voice Morph Effects are not supported
secondlife/viewer#1451
2024-07-23 17:32:59 -07:00
Brad Linden 3e4b23539c Merge remote-tracking branch 'origin/release/webrtc-voice' into release/2024.06-atlasaurus
# Conflicts:
 #	autobuild.xml
 #	indra/newview/llvoicechannel.cpp
2024-07-17 14:35:17 -07:00
Roxie Linden 3c71230aa4 don't set voice font for vivox 2024-07-02 21:03:30 -07:00
Roxie Linden af21783ffa EnableVoiceMorphing should default to true 2024-07-02 13:52:51 -07:00
Roxie Linden 3eab42ebd8 Disable voice morphing and throw up a warning if it's previously enabled. 2024-06-21 13:22:12 -07:00
Roxie Linden 5e60392c27 Merge branch 'develop' of github.com:secondlife/viewer into roxie/webrtc-voice 2024-06-13 14:59:28 -07:00
Ansariel e2e37cced8 Fix line endlings 2024-05-22 22:40:26 +03:00
Ansariel 1b67dd855c Merge remote-tracking branch 'origin/main' into DRTVWR-600-maint-A
# Conflicts:
#	autobuild.xml
#	indra/cmake/CMakeLists.txt
#	indra/cmake/GoogleMock.cmake
#	indra/llaudio/llaudioengine_fmodstudio.cpp
#	indra/llaudio/llaudioengine_fmodstudio.h
#	indra/llaudio/lllistener_fmodstudio.cpp
#	indra/llaudio/lllistener_fmodstudio.h
#	indra/llaudio/llstreamingaudio_fmodstudio.cpp
#	indra/llaudio/llstreamingaudio_fmodstudio.h
#	indra/llcharacter/llmultigesture.cpp
#	indra/llcharacter/llmultigesture.h
#	indra/llimage/llimage.cpp
#	indra/llimage/llimagepng.cpp
#	indra/llimage/llimageworker.cpp
#	indra/llimage/tests/llimageworker_test.cpp
#	indra/llmessage/tests/llmockhttpclient.h
#	indra/llprimitive/llgltfmaterial.h
#	indra/llrender/llfontfreetype.cpp
#	indra/llui/llcombobox.cpp
#	indra/llui/llfolderview.cpp
#	indra/llui/llfolderviewmodel.h
#	indra/llui/lllineeditor.cpp
#	indra/llui/lllineeditor.h
#	indra/llui/lltextbase.cpp
#	indra/llui/lltextbase.h
#	indra/llui/lltexteditor.cpp
#	indra/llui/lltextvalidate.cpp
#	indra/llui/lltextvalidate.h
#	indra/llui/lluictrl.h
#	indra/llui/llview.cpp
#	indra/llwindow/llwindowmacosx.cpp
#	indra/newview/app_settings/settings.xml
#	indra/newview/llappearancemgr.cpp
#	indra/newview/llappearancemgr.h
#	indra/newview/llavatarpropertiesprocessor.cpp
#	indra/newview/llavatarpropertiesprocessor.h
#	indra/newview/llbreadcrumbview.cpp
#	indra/newview/llbreadcrumbview.h
#	indra/newview/llbreastmotion.cpp
#	indra/newview/llbreastmotion.h
#	indra/newview/llconversationmodel.h
#	indra/newview/lldensityctrl.cpp
#	indra/newview/lldensityctrl.h
#	indra/newview/llface.inl
#	indra/newview/llfloatereditsky.cpp
#	indra/newview/llfloatereditwater.cpp
#	indra/newview/llfloateremojipicker.h
#	indra/newview/llfloaterimsessiontab.cpp
#	indra/newview/llfloaterprofiletexture.cpp
#	indra/newview/llfloaterprofiletexture.h
#	indra/newview/llgesturemgr.cpp
#	indra/newview/llgesturemgr.h
#	indra/newview/llimpanel.cpp
#	indra/newview/llimpanel.h
#	indra/newview/llinventorybridge.cpp
#	indra/newview/llinventorybridge.h
#	indra/newview/llinventoryclipboard.cpp
#	indra/newview/llinventoryclipboard.h
#	indra/newview/llinventoryfunctions.cpp
#	indra/newview/llinventoryfunctions.h
#	indra/newview/llinventorygallery.cpp
#	indra/newview/lllistbrowser.cpp
#	indra/newview/lllistbrowser.h
#	indra/newview/llpanelobjectinventory.cpp
#	indra/newview/llpanelprofile.cpp
#	indra/newview/llpanelprofile.h
#	indra/newview/llpreviewgesture.cpp
#	indra/newview/llsavedsettingsglue.cpp
#	indra/newview/llsavedsettingsglue.h
#	indra/newview/lltooldraganddrop.cpp
#	indra/newview/llurllineeditorctrl.cpp
#	indra/newview/llvectorperfoptions.cpp
#	indra/newview/llvectorperfoptions.h
#	indra/newview/llviewerparceloverlay.cpp
#	indra/newview/llviewertexlayer.cpp
#	indra/newview/llviewertexturelist.cpp
#	indra/newview/macmain.h
#	indra/test/test.cpp
2024-05-22 19:04:52 +02:00
Roxie Linden 3a212d9608 Merge branch 'spaces-merge' into roxie/webrtc-voice 2024-05-20 12:59:59 -07:00
Roxie Linden 2b275d43fb Clean up some shutdown code. 2024-05-17 13:27:45 -07:00
Roxie Linden cfd358f933 WebRTC clients calling Vivox clients should handle P2P 2024-05-16 13:34:13 -07:00
Roxie Linden c628c1f6e4 Fix some session shutdown/error handling code 2024-05-08 14:22:43 -07:00
Andrey Lihatskiy 1b68f71348 #824 Process source files in bulk: replace tabs with spaces, convert CRLF to LF, and trim trailing whitespaces as needed 2024-04-29 07:56:09 +03:00
Roxie Linden 1a1af1ce29 Adjust logic for determine what voice server type to use. 2024-04-20 00:26:39 -07:00
Roxie Linden dbbbbc55af Refactor device selection logic
This refactor fixed a few bugs.  There is an annoying 'click' when
changing devices, however.  This will be addressed in the future.
2024-03-14 20:04:39 -07:00
Roxie Linden 76460e8c2c Use LLCachedControl to speed up voice enable/disable checking 2024-03-11 22:45:36 -07:00
Roxie Linden 37837edd69 Fixup some logic relating to teleporting and new regions 2024-03-11 22:12:21 -07:00
Roxie Linden 1f177d837c fixup tabs 2024-03-11 14:41:12 -07:00
Roxie Linden fc462b2b0f Remove trailing spaces. Other code cleanup. 2024-03-10 00:11:43 -08:00
Roxie Linden 42c7a335f8 Fix issue with spatial and p2p being up at the same time
Also, fix issue with voice still happening in parcels where voice is
disabled.
2024-03-07 23:13:11 -08:00
Roxie Linden 6d5304bd92 For webrtc, 'calling' dialog should remain up, disappearing when peer connects (p2p) 2024-03-05 11:05:31 -08:00
Roxie Linden b17c668d12 fix webrtc logic bugs and such 2024-03-03 22:34:35 -08:00
Roxie Linden 2117f8c4ba Refactor for vivox spatial and p2p
General refactoring to improve vivox spacial and p2p voice
including generalizing voice info instead of just using
sip uri and credentials.  Voice server type is also passed
around in the generalized voice info blob.
2024-03-03 15:50:35 -08:00
Roxie Linden 7287cfbd7a For spatial voice, determine voice provider based on server setting. 2024-02-22 14:34:03 -08:00
Ansariel 60d3dd98a4 Convert remaining BOOL to bool 2024-02-21 23:14:31 +02:00
Ansariel 8c16ec2b53 Convert BOOL to bool in LLControlGroup and related classes 2024-02-21 03:00:25 +02:00
Roxie Linden 0cd8ad6ebb Hang up when peer hangs up in ad-hoc driven p2p call 2024-02-08 18:35:55 -08:00
Roxie Linden 0e6103e3a9 Checkpoint Ad-Hoc voice.
Unlike vivox, P2P uses the ad-hoc voice mechanism, which is also used by
group voice.
2024-02-08 18:35:21 -08:00
Roxie Linden 0ae8bbaf5d Checkpoint WebRTC Voice 2024-02-08 18:34:00 -08:00
Andrey Lihatskiy 033b04f388 Merge branch 'main' into DRTVWR-582-maint-U
# Conflicts:
#	indra/newview/llagentlistener.cpp
#	indra/newview/llcommanddispatcherlistener.cpp
#	indra/newview/llfilepicker_mac.mm
#	indra/newview/llworldmapview.cpp
2023-05-17 18:05:05 +03:00
Andrey Kleshchev daca555592 SL-19609 Urls aren't dispatched according to the indicated grid 2023-04-19 20:06:37 +03:00
Andrey Kleshchev 8032b2d72e SL-19204 Crash at removeObserver
A lot of reports about crashes in voice's removeObserver with no indication of the cause, all MAC specific. By this point terminate should have been called and mVoiceModule should be null, yet callstaks suggest it isn't.

Commit clears LLVoiceClient beforehand to avoid the issue entirely, but issue lies elsewhere and 'voice' crash is just a symptom.
2023-02-17 00:51:18 +02:00
akleshchev f7010e46af
SL-18778 Crash at LLVoiceClient::removeObserver (#25) 2022-12-06 04:37:07 +02:00
Andrey Lihatskiy 26c8883bb7 Merge remote-tracking branch 'origin/SL-18119' into DRTVWR-548-maint-N 2022-09-22 19:13:13 +03:00
Brad Payne (Vir Linden) 827420e2fe SL-18119 - bug fix 2022-09-21 20:58:34 +01:00
Brad Payne (Vir Linden) 3994101549 SL-18119 - more ViewerStats logs for NUX 2022-09-21 20:52:27 +01:00
Howard Stearns 4dfecb6e1a SL-13297 - Change names to match coding standard. 2022-01-06 16:33:38 -08:00
Howard Stearns bdd8a52dfe SL-13297 - Record and use build version reported by SLVoice 2022-01-06 15:44:21 -08:00
Andrey Lihatskiy 6240168f24 Merge branch 'master' into DRTVWR-515-maint 2021-04-01 20:45:06 +03:00