The bug seems to happen when the text contains trailing newlines.
So the workaround is to strip those newlines.
I use a workaround because a proper fix might require changing LLTextBase which is undesirable at this point.
Reviewed by Mike Antipov at https://codereview.productengine.com/secondlife/r/722/
--HG--
branch : product-engine
Every single delete/create operation in the COF causes LLCOFWearables to be updated - on each update its contained LLFlatListView is repopulated. That means massive creation of LLPanel's instances (LLUICtrlFactory::buildPanel(...)). Half of the panel creation time is spent in the EXPAT xml library on parsing the .xml files of the panel item.
I've forbidden updates of LLCOFWearables when Panel Outfit Edit is not in the visible chain. Panel Outfit Edit is now updated only when it is visible
Also LLCOFWearables refures to refresh its content if COF category version hasn't been changed since the last refresh.
Reviewed by Neal Orman at https://codereview.productengine.com/secondlife/r/715
--HG--
branch : product-engine
Replacing logic with call to removeCOFItemLinks, which should do appropriate
checking to determine that item is in the COF and is actually a link.
Code reviewed by Seraph
Made LLPanelOutfitEdit::onPlusBtnClicked() iterate over all selected items and wear each one. Also made it create one LLUpdateAppearanceOnDestroy and pass it to all calls to wearItemOnAvatar.
Add optional callback argument (as LLPointer) to wearItemOnAvatar, addCOFItemLink, LLDeferredCOFLinkObserver
Reviewed by Nyx at http://codereview.lindenlab.com/2482033
- Switched order of 'Share' checkbox and 'Deed' button
- Switched order of 'Group Name' name box and 'Set Group' button
- Changed image_overlay of 'Set Group' button
Reviewed by Vadim Savchuk at https://codereview.productengine.com/secondlife/r/717/
--HG--
branch : product-engine
Details:
Provided resetting hovered toast field in screen channel when toast destroyed along viewer logging out.
reviewed by Vadim Savchuk at https://codereview.productengine.com/secondlife/r/705/
--HG--
branch : product-engine
Used to assert that the inventory's stored wearable type data matched the
asset's stored wearable type, leading to a crash when these did not line up.
Converted the assert to a check with llwarns for when this happens.
code reviewed by vir
- Localized the "New Shoes" string.
I'm sceptical about this fix. Let's see if the translation team accepts it.
If not, I'll add a bunch of new translatable strings like "Create new shoes", "Create new pants", etc.
- Translated the "Replace" item of clothing context menu (took translation from the body part context menu).
Reviewed by Nyx at https://codereview.productengine.com/secondlife/r/710/
--HG--
branch : product-engine
Vadim Savchuk