The point of this patch is to make the Mac updater code a bit more flexible
and reliable than it is right now. The issue is double:
* reliability: the string comparison code on the bundle identifier is not UTF8 compliant
* flexibility: the bundle identifier is hard coded to match the bundle identifier of LL viewer
(i.e. com.secondlife.indra.viewer) so it can't work for another viewer
(in particular, it didn't work for Snowglobe).
The "bundle identifier" is one of those Mac only thing stored in the Info.plist of a "bundle"
(the ".app" folder that's bundling an executable and all its resources and is seen
as an application when browsing with the Mac OS X Finder).
The patch fixes both issues:
* compare correctly UTF8 encoded strings
* allow the bundle ID to be passed as a parameter to the updater
The patch has really no consequence on LL viewer. It's more a matter of having cleaner, better code.
Author: Cypren Christenson
Ported and reviewed by: Merov Linden
Added polish language to list of languages that use months and days names from localized xmls.
It solved the problem of accented Polish characters "approximation" to their ASCII brethren on non-Polish Windows locales. Now all accented symbols look right.
Bug reason
==========
New inventory items get names like "New Script", "New Undershirt" etc., but the names are translated on-the-fly (see EXT-5839), so the user actually sees "Nouveau script", "Nouveau débardeur" etc., respectively.
However when the user changes viewer language, the old localized names still exist in the inventory cache, so, for example, if you create an undershirt in French and then switch to Enlgish, the undershirt will be named "Nouveau d bardeur", which is the old cached localized name with non-ASCII characters replaced with spaces.
Fix
===
To get rid of obsolete translations I clear all caches whenever viewer language gets changed.
Other changes
=============
- Added a check for agent region being NULL to LLAgentLanguage::update().
- Removed LLAgentLanguage constructor and base classes because it's never instantiated.
Reviewed by Seraph at https://codereview.productengine.com/secondlife/r/744/
--HG--
branch : product-engine
Merov Linden