Nicky
f7e7903105
Fix ASAN errors from LLVector4a::memcpyNonAliased16
...
Found by running with -fsanitze=thread
Suggestion to avoid accessing invalid memory:
In both cases memory will be allocated by can be accessed beyond bounds.
In LLPolyMesh it can be off by at least one (+x%2). Though I am not even sure if even in best case it always will be a multiple of 16.
In LLViewerJointMesh::updateFaceData the code tries to account for padding by, but the allocation in LLPolyMeshSharedData::allocateVertexData is done without any padding. Thus the sizes must not match.
Replacing the calls with memcpy as a quick fix to see if the error goes away fixed address sanitzer complaining.
It is up to debate if memcpy is a good replacement. LLVector4a::memcpyNonAliased16 was invented for performance. But on the other hand one could argue that nowadays every stdlib maintainer will very heavily optmize functions like memcpy themselves and could take advantage of CPU features the old LL implementation does not take into account.
AVX comes to mind. In any case did I not measure any of this.
2025-03-11 03:21:43 +02:00
Andrey Kleshchev
a925b178b0
triage#163 'Create folder from selected' misbehaves in marketplace
...
Marketplace deliberately doesn't allow creating folders and the "New
folder from selected" is a way of creating a new folder then moving
selected items inside, therefore shouldn't be allowed.
2025-03-11 03:13:10 +02:00
Andrey Lihatskiy
c864e6a8b3
Build fix
2025-03-11 03:12:39 +02:00
Andrey Kleshchev
ea7b63ffbf
viewer#1114 Expose max impostors setting in basic graphics preferences
...
# Conflicts:
# indra/newview/llfloaterpreferencesgraphicsadvanced.cpp
2025-03-11 01:55:50 +02:00
Andrey Kleshchev
d8f3c242d4
viewer#1104 Crash at populateFoldersList
...
Ensure folder creation callbacks remain alive
# Conflicts:
# indra/newview/llfloatercreatelandmark.cpp
# indra/newview/llfloatercreatelandmark.h
2025-03-11 01:41:05 +02:00
Andrey Kleshchev
f2042fe9d8
triage#150 on OSX any file can be chosen for model upload
...
# Conflicts:
# indra/newview/llfilepicker.cpp
2025-03-11 01:39:10 +02:00
Bennett Goble
483b4fa993
BUG-134040: Fix broken SOCKS5 proxy
...
Second Life's SOCKS5 proxy has been broken on windows for at least six
years due to a conflation of milliseconds and microseconds in the APR
timeout value used when attempting to ping the proxy.
# Conflicts:
# indra/llmessage/llproxy.cpp
2025-03-11 01:38:10 +02:00
Andrey Kleshchev
41db7cb9a5
viewer#1061 Altitudes are invisible in region's environment
2025-03-11 01:34:27 +02:00
Andrey Kleshchev
e6f904f5c1
viewer#1016 Incorrect behavior of Physics Shapes rendering
...
# Conflicts:
# indra/newview/llphysicsshapebuilderutil.cpp
2025-03-11 01:34:12 +02:00
Andrey Kleshchev
9ed1e92016
viewer-private#217 Rotate cef log file
...
# Conflicts:
# indra/newview/llviewermedia.cpp
2025-03-11 01:30:59 +02:00
Andrey Kleshchev
83ded06e0c
viewer-private#216 Viewer fails to rename vivox logs
2025-03-11 01:27:29 +02:00
Andrey Kleshchev
84345d7140
viewer#970 Fixed param validation warnings
...
# Conflicts:
# indra/newview/llfloateremojipicker.cpp
# indra/newview/skins/default/xui/en/floater_fast_timers.xml
2025-03-11 01:27:09 +02:00
Andrey Kleshchev
0e26d7717d
viewer#945 Some worn items are missing from Avatar floater's Outfits tab
...
# Conflicts:
# indra/newview/lloutfitslist.cpp
2025-03-11 01:23:53 +02:00
Cosmic Linden
065eddb8bf
secondlife/viewer-issues#75 : Remove "HTTP Textures" setting in Developer menu
2025-03-11 01:21:07 +02:00
Mnikolenko Productengine
2648d5cdc8
Merge branch 'main' into release/2025.03
2025-03-11 00:34:12 +02:00
Jonathan "Geenz" Goodman
573ca63e0f
Merge pull request #3684 from secondlife/andreyk/viewer_3569
...
#3569 Pull in some fixes from forevermac
2025-03-06 15:38:35 -05:00
Jonathan "Geenz" Goodman
37b26062cf
Merge pull request #3686 from secondlife/main
...
Merge pull request #3304 from secondlife/release/2024.12-ForeverFPS
2025-03-06 15:24:26 -05:00
Jonathan "Geenz" Goodman
e6927d8a07
Merge pull request #3304 from secondlife/release/2024.12-ForeverFPS
...
2024.12 ForeverFPS
2025-03-06 15:23:54 -05:00
Jonathan "Geenz" Goodman
86774bb53f
Merge pull request #3682 from VectorMutt/rye/fixprefsearch
...
Fix preferences search not finding text defined in text boxes (#3653 )
2025-03-06 15:12:34 -05:00
Andrey Kleshchev
d8fbfb4e1a
#3569 Update OpenAL-Soft to 1.24.2
2025-03-06 21:25:30 +02:00
Rye
3cc7264108
Fix preferences search not finding text defined in text boxes ( #3653 )
2025-03-06 14:09:29 -05:00
Rye
b0bc83800e
Fix crash from socket creation failure in media plugin system
2025-03-06 20:57:21 +02:00
Rye
9ce9f6c741
Fix openal leak causing crash during shutdown
2025-03-06 20:56:25 +02:00
Andrey Kleshchev
b8eda5b115
#3673 Crash at updateImageDecodePriority
2025-03-06 20:55:39 +02:00
Andrey Kleshchev
9d1d8690bf
#3673 Crash at updateImageDecodePriority
2025-03-06 20:02:46 +02:00
Jonathan "Geenz" Goodman
2f031e03d6
Merge pull request #3657 from secondlife/maxim/2025.03-develop-fixes
...
Cherry-picking develop fixes into 2025.03
2025-03-06 12:29:59 -05:00
Andrey Kleshchev
616547993a
#3654 Searchable disabled settings not readable when highlighted
2025-03-06 08:50:53 +02:00
Jonathan "Geenz" Goodman
aa060ae56c
Quick fix for water exclusion. ( #3666 )
...
* Fix for water exclusion when shoreline fade is disabled.
2025-03-06 00:51:59 +00:00
Jonathan "Geenz" Goodman
59495b81cc
Hide shoreline fade behind a shader variant. ( #3665 )
...
#3650 Fixed transparent particles over water make the water look black under their transparent parts
2025-03-05 19:42:30 -05:00
Jonathan "Geenz" Goodman
51f2504cfe
AMD NaN and inf propagation mitigation - #3663 ( #3664 )
...
#3663 On AMD, the world may be rendered in really strange colors.
2025-03-05 19:23:24 -05:00
Jonathan "Geenz" Goodman
f5a25a9d6a
Add RenderTextureVRAMDivisor ( #3648 )
...
#3647 Add texture VRAM use divisor.
2025-03-05 19:06:01 -05:00
Andrey Kleshchev
85c77ee910
#3611 Decrease TextureScaleMinAreaFactor
2025-03-05 23:00:01 +02:00
Maxim Nikolenko
2dfa996db7
#2626 fix for incoming IM calls not being rejected when DND mode is active
2025-03-05 16:12:50 +02:00
Maxim Nikolenko
f93493cb27
#2711 Remove ALM text from About SL
2025-03-05 15:48:25 +02:00
Maxim Nikolenko
1a4af23402
#3256 force undampened movement for attached animated linkset in mouselook
2025-03-05 15:42:27 +02:00
Maxim Nikolenko
ef915c4c58
#3314 update labels to match Render Quality setting
2025-03-05 15:23:55 +02:00
Maxim Nikolenko
559ce54d50
#3072 don't update UI on cancel event from texture picker
2025-03-05 15:16:14 +02:00
Maxim Nikolenko
2ea170ca5a
#3051 fix for Group notices get logged into wrong file
2025-03-05 13:44:31 +02:00
Maxim Nikolenko
8520ca966f
#3052 remove pointless logging when group notice is received
2025-03-05 13:36:40 +02:00
Andrey Kleshchev
5c2a331c44
#3644 Fix new logging of packet drops hitting performance #2
...
Misunderstood how mDroppedPackets worked, clear out what's not needed
2025-03-05 13:32:46 +02:00
Maxim Nikolenko
2f61475d98
#3029 restore tooltip delay const variable
2025-03-05 13:16:32 +02:00
Maxim Nikolenko
6ca6bdd629
#3630 fix for incorrectly pointed particle beam after dropping HUD attachment
2025-03-04 21:32:46 +02:00
Andrey Kleshchev
3efe5b4934
#3644 Fix new logging of packet drops hitting performance
2025-03-04 21:15:15 +02:00
Andrey Kleshchev
c98002daa6
#3643 Use bugsplat attributes on MacOS
2025-03-04 17:23:05 +02:00
Andrey Kleshchev
ed394cd5a0
#3591 rethrow should be mac specific
...
Jumped the gun a bit, since reportCrashToBugsplat is OS specific,
restore rethrow for other systems.
2025-03-04 17:23:05 +02:00
Maxim Nikolenko
a1ccb44c15
#3512 Add UX for marking water exclusion surfaces
2025-03-03 22:29:26 +02:00
Jonathan "Geenz" Goodman
5d78ff48cb
Merge pull request #3634 from secondlife/release/2024.12-ForeverFPS
...
Update develop with ForeverFPS
2025-03-01 16:37:59 -05:00
Jonathan "Geenz" Goodman
5aa359ed8d
Merge pull request #3626 from secondlife/rider/transfer_message
...
https://github.com/secondlife/server/issues/1493 New notification for transfer ownership
2025-03-01 16:37:17 -05:00
Jonathan "Geenz" Goodman
8c671a017a
Merge pull request #3623 from secondlife/rider/server_autopilot
...
https://github.com/secondlife/server/issues/966 Honor flag sent by server indicating server side autopilot is engaged. When flag is set allow server to update local avatar rotation.
2025-03-01 16:31:15 -05:00
Jonathan "Geenz" Goodman
ea79f8f613
Merge pull request #3624 from secondlife/rider/map_beacon
...
https://github.com/secondlife/viewer-private/issues/297 Local beacons via script
2025-03-01 14:59:15 -05:00