Previous fix was not correct. The underlying issue is that the cached `mAvatar` pointer is being invalidated and as a result crashing.
using avatarp instead avoids this and removes the awkward cached pointer. Might need to review if the previous reason for mAvatar reappears.
This is evidently a race condition, not everyone is crashing and according to LL it does not repro in DeltaFPS (though it does in Atlasaurus for them too). This probably suggests that DeltaFPS just happened to move the race condition needle a little in the right direction.
Fix for mAvatar not initialised when single_avatar is null.
Also added additional null checks in the avatar rendering process to prevent potential null dereference issues.
* #2434 Intel HD4000 compatibility pass
* Fixes crash on old drivers when loading shaders
* Fixes 30 second hang on startup
* Fixes occasional dev build crash in LLWearableList
---------
Co-authored-by: Brad Linden <brad@lindenlab.com>
Borrowed from LL:
IThe BugsplatMac framework currently causes Gatekeeper popups at viewer start.
LL used this code to workaround that. Perhaps it will work for us?
The update also ensures that 'strip' keeps enough info for annotated backtraces, making crash logs more useful.
Applying a correction to replace the non-existent NotoSans.ttf as the default fallback.
It has been "wrong" for a long time suggesting that it was an unrelated change (possibly aligning our fallbacks with LL) that triggered this, so there may be other issues.
We may need to review this further if it has other side-effects.
Previously, an assertion failure would occur if mComplete.size() was zero. This has been downgraded to a warning message and early return, improving stability especially for large inventories or slow grid asset servers.
Ansariel