Commit Graph

47788 Commits (cdc9852f052d804f8b25564ab7d90eb2b79cddd4)

Author SHA1 Message Date
RunitaiLinden cdc9852f05 SL-19709 Fix for fullbright shiny not factoring out exposure and flickering fullbright alpha. Incidental decruft. 2023-05-15 11:01:24 -05:00
RunitaiLinden e3f9244375 SL-19710 Fix for deadlock in LLPerfStats. Move General thread initialization to earlier in session (unrelated). 2023-05-12 18:09:35 -05:00
Brad Linden 06bdee6634 Xcode build fixes for DRTVWR-559 2023-05-11 12:18:45 -07:00
cosmic-linden 3914c4ce16
Merge pull request #212 from secondlife/SL-19236
SL-19236: Fix HUDs not rendering when transparent water graphics setting is off
2023-05-11 11:39:04 -07:00
Cosmic Linden 7d0903533c SL-19236: Fix HUDs not rendering when transparent water graphics setting is off 2023-05-11 11:31:09 -07:00
RunitaiLinden b8575bd1bd Merge branch 'DRTVWR-559' of github.com:secondlife/viewer into DRTVWR-559 2023-05-11 13:21:00 -05:00
RunitaiLinden 8077d33ba0 SL-19656 Remove LLPerfStats thread and fold into General thread. Hook avatar GPU time into LLPerfStats. Incidental decruft. 2023-05-11 13:20:34 -05:00
nat-goodspeed 69d444826d
Merge pull request #208 from secondlife/SL-19690
SL-19690: Follow up on Rye Mutt's fix for shutdown crashes.
2023-05-10 09:14:14 -04:00
RunitaiLinden 0b1c0aa242 Merge branch 'DRTVWR-559' of github.com:secondlife/viewer into DRTVWR-559 2023-05-08 15:21:23 -05:00
RunitaiLinden 3f1f126186 DRTVWR-559 Remove main window proc printf debugging. 2023-05-08 15:21:04 -05:00
cosmic-linden 06be53fef7
Merge pull request #206 from secondlife/SL-19644
SL-19644: De-virtualize pushBatch
2023-05-08 11:05:24 -07:00
Nat Goodspeed f728808d93 SL-19690: Fix a lingering reference to WorkSchedule::postIfOpen() 2023-05-08 12:45:27 -04:00
Nat Goodspeed d75ecde69c SL-19690: Properly qualify exception type. 2023-05-08 12:31:57 -04:00
Nat Goodspeed 026ef1935d SL-19690: Follow up on Rye Mutt's fix for shutdown crashes.
Rather than continuing to propagate try/catch (Closed)
(aka LLThreadSafeQueueInterrupt) constructs through the code base, make
WorkQueueBase::post() return bool indicating success (i.e. ! isClosed()).
This obviates postIfOpen(), which no one was using anyway.

In effect, postIfOpen() is renamed post(), bypassing the exception when
isClosed().

Review existing try/catch blocks of that sort, changing to test for post()
returning false.
2023-05-08 12:07:31 -04:00
Andrey Kleshchev 6d0d9b8e54 SL-19690 Updated contribution doc 2023-05-08 18:28:33 +03:00
akleshchev db30ffc7cb
SL-19690 Merge pull request #207 from RyeMutt/shutdown-crash
Fix exceptions during shutdown causing early program termination
2023-05-08 18:25:12 +03:00
Rye Mutt 855cae27cc Fix LLThreadSafeQueueInterrupt in WorkQueueBase::postTo during shutdown by catching and returning false 2023-05-05 17:23:29 -04:00
Rye Mutt 6954aafb5d Fix uncaught LLThreadSafeQueueInterrupt during ImageWorker threadpool shutdown 2023-05-05 17:20:48 -04:00
Cosmic Linden 307d31116d SL-19644: De-virtualize pushBatch
Bump still uses its own pushBumpBatch function - OK, works the same as
before.
2023-05-05 11:32:56 -07:00
Nat Goodspeed 5ce70325ce DRTVWR-559: Hard tabs considered harmful 2023-05-05 09:52:22 -04:00
Andrey Kleshchev 572d313bcf DRTVWR-559 LLSD array build fix 2023-05-04 23:06:00 +03:00
Andrey Kleshchev f8f119e4a8 SL-18932 Canceling material selection only reverts override 2023-05-04 22:46:39 +03:00
Brad Linden 7c1ccdc9a4
Merge pull request #179 from secondlife/brad/mac-nightly-builds
enable github actions mac nightly builds
2023-05-04 11:49:33 -07:00
Brad Linden a22d62e8ed Merge remote-tracking branch 'origin/zap-LLSDArray' into DRTVWR-559 2023-05-04 11:39:03 -07:00
Brad Linden 52f8ff9961 Merge remote-tracking branch 'origin/SL-19594-restore' into DRTVWR-559 2023-05-04 11:38:52 -07:00
Brad Linden c75b0079d9 Fix typo 2023-05-04 11:28:29 -07:00
nat-goodspeed 66413dfa38
Merge pull request #203 from secondlife/DRTVWR-559-zapfunc
DRTVWR-559: Replace debugLoggingEnabled() function with LL_DEBUGS().
2023-05-04 13:39:59 -04:00
Brad Linden 13d372adea Switch mac build to go on hosted macos-12-xl runner. 2023-05-04 10:26:18 -07:00
Nat Goodspeed e3f3eea825 DRTVWR-559: Add <unordered_map> header since we use it. 2023-05-04 10:21:28 -04:00
Nat Goodspeed 1910eb6ae6 SL-19594: Update to bugsplat build 579669 2023-05-04 09:34:37 -04:00
Nat Goodspeed a57013082d DRTVWR-559: Merge 'DRTVWR-559' into DRTVWR-559-zapfunc 2023-05-04 09:01:22 -04:00
Brad Linden 7d23f91b16 Added ability to disable required OSX_SYSROOT cmake checks 2023-05-03 15:47:19 -07:00
RunitaiLinden a9dca45773 Merge branch 'DRTVWR-559' of github.com:secondlife/viewer into DRTVWR-559 2023-05-03 17:31:24 -05:00
RunitaiLinden 1cadfd44fe DRTVWR-559 WIP - optimize ARC calculation et al. 2023-05-03 17:30:02 -05:00
Brad Linden e41cb7b5db Further attempts to get actions based nightly mac builds working for DRTVWR-559 2023-05-03 15:23:32 -07:00
Brad Linden 9096c8d06f Experiment with turning on MacOS builds for github based nightly builds for DRTVWR-559 2023-05-03 14:59:53 -07:00
Nat Goodspeed e7c5b9fb0f SL-19647: Eliminate LLSDArray entirely.
Newer C++ compilers have different semantics around LLSDArray's special copy
constructor, which was essential to proper LLSD nesting. In short, we can no
longer trust LLSDArray to behave correctly. Now that we have variadic
functions, get rid of LLSDArray and replace every reference with llsd::array().
2023-05-03 17:38:30 -04:00
Brad Linden b985a69968
Merge pull request #191 from secondlife/brad/SL-19648-refcount-llgltfmaterial-thread-safety
Fix SL-19675 crash due to thread unsafe LLRefCount usage possibly related to SL-19648
2023-05-03 14:16:34 -07:00
Brad Linden 5465594a34 Cleanup with SL-19675 fix. lifted empty check outside the workqueue post and cleaned up indentation 2023-05-03 13:30:33 -07:00
Brad Linden 6a812fa1ba Improved fix for SL-19675 crash. How about just don't refer to data when you don't need it 2023-05-03 13:30:33 -07:00
Brad Linden 799d7605a9 Merge remote-tracking branch 'origin/main' into DRTVWR-559 2023-05-03 12:31:25 -07:00
Nat Goodspeed 3c77c1b90f DRTVWR-575: Replace some LLSDArray() usage with llsd::array().
It seems newer compilers have a different interpretation of exactly when to
engage LLSDArray's copy constructor. In particular, this assignment:

some_LLSD_map[key] = LLSDArray(...)(...)...;

used to convert the LLSDArray object directly to LLSD; now it first calls the
custom copy constructor, which embeds the intended array within an outer array
before assigning it into the containing map.

The newer llsd::array() function avoids that problem because what it returns
is already an LLSD object.

Taking inventory of LLSDArray assignments of that form turned up a number of
workarounds like LLSD(LLSDArray(...)). Replacing those with llsd::array() is
both simpler and more readable.

Tip of the hat to Chorazinallen for surfacing this issue!

(cherry picked from commit bb718155bd)
2023-05-03 12:31:42 -04:00
Nat Goodspeed 21ddaa6908 DRTVWR-559: Merge remote branch 'DRTVWR-559' into DRTVWR-559-zapfunc
Delete the debugLoggingEnabled() (changed to LL_DEBUGS()) stanzas deleted by
the upstream.
2023-05-03 10:01:39 -04:00
Nat Goodspeed 2a10bd406c DRTVWR-559: Replace debugLoggingEnabled() function with LL_DEBUGS().
The trouble with debugLoggingEnabled() is that it locked mutexes and searched
maps every time that call was reached. LL_DEBUGS() has the same functionality
(albeit with idiosyncratic syntax) but performs expensive lookups only once
per session, caching the result in a local static variable.
2023-05-03 09:55:31 -04:00
RunitaiLinden e09475713b DRTVWR-559 Optimization pass, make it so profileAvatar can read back GPU timer without a frame stall. 2023-05-02 18:47:21 -05:00
Brad Linden 3513f67d2c Attempt at fixing thread safety possibly related to SL-19648 2023-05-02 15:57:49 -07:00
Vir Linden 7ed52090a6 Increment viewer version to 6.6.12
following promotion of DRTVWR-539
2023-05-02 10:24:54 -04:00
Brad Linden 2994833e7c SL-19656 followup removing unused variable 2023-05-01 17:24:07 -07:00
RunitaiLinden 334d71e910
SL-19656 Rewrite avatar and attachment render metrics to not interfere with render pipe and be representative of actual render cost instead of driver synchronization time.
* SL-19656 Rewrite avatar and attachment render metrics to not interfere with render pipe and be representative of actual render cost instead of driver synchronization time.

* SL-19656 Remove now dead code (trackAttachments et al).

* SL-19656 Fix for crash on GL <= 3.2
2023-05-01 17:05:09 -05:00
cosmic-linden 04604a921d
Merge pull request #196 from secondlife/SL-19644
SL-19644: Move GLTF transform reset out of pushBatch
2023-04-28 13:21:33 -07:00