The manual control for the Limit VRAM texture usage in the Preferences->Graphics->Hardware Settings did not restore the saved value of the slider upload load.
So when the viewer would load, it would indeed load the saved value, but the value was not reflected upon by the slider on the page. This caused issues of when a user went to move the slide back to it's intended position it would set off the bias system as well as make the user not have confidence in that the feature is working.
Added a call to the ser value of the UI control on refresh enable state of the UI floater for the preferences to the saved RenderMaxVRAMBudget.
Fixed the blurry texture issue with a couple of fixes.
Objects selected by by the user would gain a BOOST_SELECTED boost level, but when unselected the system did not store the old value and would get turned to BOOST_NONE which allows the Bias system to further downscale the image lower then the original size.
Upon first loading a texture, if the desired size was lower then what was decoded, it would auto scale down the new texture, without first validating if the texture was allowed to be scaled down due to type of texture.
Further, the rules applied to the LLViewerTextureList::updateImageDecodePriority would apply to all textures on screen no matter what type as long as the boost was lower then BOOST_HIGH.
Changes include new mPrevBoostLevel for any texture with accessor methods to restore the values and updated the code which first set's the boost level to BOOST_SELECTED to store the boost level of all affected objects before changing the boost level.
Added LL's "Fix" for the bias by forcing to to stay static if VRAM or System RAM is at 10% of max.
Added logic to the updateImageDecodePriority to not apply bias to non LOD textures as well as any texture which has a current discard of 0 or 1, so not to blur high res images close to the screen.
Added logic to updateImagesCreateTextures to only scale down LOD textures which have a boost level < BOOST_HIGH
Added sPrevDesiredDiscardBiasto keep track other previous bias value before it was updated to allow for better control of the system handling bias effects such if the bias value is not chanigng, use the normal number of texture updates.
Fixed up the Developer -> Consoles -> Texture Console to have correct values for the
llformat("Tex: %d Fetch: %d(%d) Pkts:%d(%d) CAC R/W: %d/%d LFS:%d RAW:%d HTP:%d DEC:%d CRE:%d FCA:%d ",
line.
This commit encompasses a significant refactor and enhancement of both the Phototools and Fixed Environment floaters, addressing user feedback, preparing for localization, incorporating feature updates, and resolving a build error. Key changes include:
- **Build Fix:** Resolved a build error caused by a duplicated line in C++ code (likely a merge artifact), ensuring cleaner compilation.
- **Phototools Floater UI - Layout & Localization:** Floater resized and layout adjusted to accommodate label localization and fix UI clipping issues.
- **Phototools Floater - Environment (Env) Tab - Preset Management & Bug Fixes:**
- Added "New Day Preset" button.
- **Removed (commented out) "Edit Sky Preset" and "Edit Water Preset" buttons.** These buttons are currently launching the environment editor without providing the necessary inventory UUID of the setting being edited, leading to improper functionality. This issue will be addressed in a future update.
- Resolved "Water Reflection Res." setting functionality issue.
- **Phototools Floater - Reflection Settings (Env Tab) - Feature Addition:** Introduced "Reflection Distance" setting in Reflection Probe options.
- **Phototools Floater - Shadow (Shdw) Tab - UI Clarity & Bug Fixes:**
- Improved "Shdw" tab label clarity.
- Corrected "Loc Lights" range and default value inconsistencies.
- Fixed duplicate UI element names ("Loc Light slider," "Irrad Max") for localization.
- Corrected "Shd Bias" slider default value.
- **Phototools Floater - VFX Tab - Tooltip & Labeling Bug Fixes:**
- Clarified "Shd Soften" tooltip (shadows vs. AO).
- Corrected "Tone Mix" label name.
- **Phototools Floater - General (Gen) Tab - Bug Fix:** Fixed "Avi Count" default button.
- **Fixed Environment Floater - UI Refactor:** Resized and rewrote the layout of the Fixed Environment floater (`floater_fs_fixedenvironment.xml`) along with nested panels for improved localization.
- **General UI Enhancements (Both Floaters):** Improved tooltips across both Phototools and Fixed Environment floaters for clarity and localization; updated labels for better user experience and translatability.
These changes enhance UI clarity and consistency across key floaters, address specific bugs reported by users, incorporate new features like "Reflection Distance" and "Day Presets," resolve a build error, and ensure improved localization readiness for both the Phototools and Fixed Environment UI components.
Beq